Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider blocking TaskLoggingHelper use after its task ends #4828

Open
rainersigwald opened this issue Oct 17, 2019 · 1 comment
Open

Consider blocking TaskLoggingHelper use after its task ends #4828

rainersigwald opened this issue Oct 17, 2019 · 1 comment
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. triaged

Comments

@rainersigwald
Copy link
Member

see #4792 (comment) and the rest of that thread

If you hold onto a TaskLoggingHelper object (perhaps in a static field) past the lifetime of the Task that created it, it will throw when it is used.

We could instead dispose of it and provide a nicer error at time of use.
@rainersigwald rainersigwald added the Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. label Oct 17, 2019
@rainersigwald rainersigwald mentioned this issue Oct 22, 2019
Closed
@KirillOsenkov
Copy link
Member

@jeromelaban is reporting he's seeing what I think is the same issue: an orphaned LoggingService: https://source.dot.net/#Microsoft.Build/BackEnd/Components/Logging/LoggingService.cs,ee48c26bd0246ed6,references

@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KirillOsenkov @rainersigwald @AR-May