From 0c490d9aee4d6f4beae57ad61f16527cdc91216c Mon Sep 17 00:00:00 2001 From: Ben Villalobos <4691428+BenVillalobos@users.noreply.github.com> Date: Wed, 23 Jun 2021 15:07:50 -0700 Subject: [PATCH 1/3] Default to transitively copying content items --- src/Tasks/Microsoft.Common.CurrentVersion.targets | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Tasks/Microsoft.Common.CurrentVersion.targets b/src/Tasks/Microsoft.Common.CurrentVersion.targets index c4ca46d34c6..1c8ab984a1f 100644 --- a/src/Tasks/Microsoft.Common.CurrentVersion.targets +++ b/src/Tasks/Microsoft.Common.CurrentVersion.targets @@ -4735,9 +4735,10 @@ Copyright (C) Microsoft Corporation. All rights reserved. GetCopyToOutputDirectoryItems depends on an unspecified dependency _SplitProjectReferencesByFileExistence -> AssignProjectConfiguration (https://github.com/microsoft/msbuild/issues/4677). When the unspecified dependency does not happen by accident, content copying is only 1 level deep instead of transitive. This target enforces the dependency. - - TODO: make transitive content copying the default when the breaking change is acceptable. --> + + true + <_TargetsThatPrepareProjectReferences Condition=" '$(MSBuildCopyContentTransitively)' == 'true' "> AssignProjectConfiguration; _SplitProjectReferencesByFileExistence From f69f5249d6cd96d157a4fa9522d33c3d93241ea5 Mon Sep 17 00:00:00 2001 From: Ben Villalobos <4691428+BenVillalobos@users.noreply.github.com> Date: Thu, 24 Jun 2021 11:20:34 -0700 Subject: [PATCH 2/3] Update src/Tasks/Microsoft.Common.CurrentVersion.targets Co-authored-by: Rainer Sigwald --- src/Tasks/Microsoft.Common.CurrentVersion.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tasks/Microsoft.Common.CurrentVersion.targets b/src/Tasks/Microsoft.Common.CurrentVersion.targets index 1c8ab984a1f..d4bd8f8cd26 100644 --- a/src/Tasks/Microsoft.Common.CurrentVersion.targets +++ b/src/Tasks/Microsoft.Common.CurrentVersion.targets @@ -4737,7 +4737,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. This target enforces the dependency. --> - true + true <_TargetsThatPrepareProjectReferences Condition=" '$(MSBuildCopyContentTransitively)' == 'true' "> AssignProjectConfiguration; From 121d47700d4520f5a933af8c94dc35dfe403a5c1 Mon Sep 17 00:00:00 2001 From: Ben Villalobos <4691428+BenVillalobos@users.noreply.github.com> Date: Wed, 30 Jun 2021 13:34:32 -0700 Subject: [PATCH 3/3] Add PR to change wave doc --- documentation/wiki/ChangeWaves.md | 1 + 1 file changed, 1 insertion(+) diff --git a/documentation/wiki/ChangeWaves.md b/documentation/wiki/ChangeWaves.md index 66b119cd485..139a8e46911 100644 --- a/documentation/wiki/ChangeWaves.md +++ b/documentation/wiki/ChangeWaves.md @@ -29,5 +29,6 @@ The opt-out comes in the form of setting the environment variable `MSBuildDisabl - [Allow users that have certain special characters in their username to build successfully when using exec](https://github.com/dotnet/msbuild/pull/6223) - [Fail restore operations when an SDK is unresolveable](https://github.com/dotnet/msbuild/pull/6430) ### 17.0 +- [Default to transitively copying content items](https://github.com/dotnet/msbuild/pull/6622) ## Change Waves No Longer In Rotation