Unable to start Redis reminder. 'Orleans.Timers.IReminderRegistry' has not been registered.

[idanbenyehoshua]

Hi,
Trying to use reminder backed by Redis but when I try to get an reminder or register new reminder I get the message (in exception):
The requested service 'Orleans.Timers.IReminderRegistry' has not been registered. To avoid this exception, either register a component to provide the service, check for service registration using IsRegistered(), or use the ResolveOptional() method to resolve an optional dependency.
I register the reminder like that:
siloBuilder.UseRedisReminderService((opt) => opt.ConfigurationOptions = myRedisConfiguration). Configure<ClusterOptions>((opt) => opt.ServiceId = "myService");
when I replace the reminder with UseInMemoryReminderService it works perfect.
** I register the Redis persistence storage exactly like UseRedisReminderService (opt.ConfigurationOptions = myRedisConfiguration) and it works as excepted.
Nuget: Microsoft.Orleans.Reminders.Redis 7.1.2-beta1

[idanbenyehoshua]

I think I found the problem, AddReminder is missing.
When I manually add siloBuilder.AddReminders(); it works.
I would like to fix it and create PR. Can someone please explain what is the procedure to create PR?
I cloned this repo to my local machine and fix it locally. From here, how can I open PR?
Thanks.

[snovak7]

@ReubenBond was this perhaps fixed in 7.2.1? Based on

orleans/src/Redis/Orleans.Reminders.Redis/Hosting/SiloBuilderReminderExtensions.cs

Lines 27 to 31 in 28256db

	public static ISiloBuilder UseRedisReminderService(this ISiloBuilder builder, Action<RedisReminderTableOptions> configure)
	{
	builder.ConfigureServices(services => services.UseRedisReminderService(configure));
	return builder;
	}

It's missing AddReminders() like here:

orleans/src/Orleans.Reminders/Hosting/SiloBuilderReminderMemoryExtensions.cs

Lines 21 to 28 in 28256db

	public static ISiloBuilder UseInMemoryReminderService(this ISiloBuilder builder)
	{
	builder.AddReminders();
	// The reminder table is a reference to a singleton IReminderTableGrain.
	builder.ConfigureServices(services => services.UseInMemoryReminderService());
	return builder;
	}

[ReubenBond]

Good point, @snovak7. I've opened a PR to fix it: #8629