Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 2 Regressions on 10/31/2022 10:23:25 PM #9571

Closed
performanceautofiler bot opened this issue Nov 8, 2022 · 1 comment
Closed

[Perf] Windows/x64: 2 Regressions on 10/31/2022 10:23:25 PM #9571

performanceautofiler bot opened this issue Nov 8, 2022 · 1 comment

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Nov 8, 2022

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 3d9d78c63c5ad9a2ed15b2c863f989a8cef2a8b9
Compare 7d5efbb9e10b6d8beb91c90cbdefd7360869cece
Diff Diff

Regressions in System.Text.Json.Tests.Utf8JsonReaderCommentsTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Utf8JsonReaderCommentParsing - Duration of single invocation 117.76 ns 125.65 ns 1.07 0.04 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Tests.Utf8JsonReaderCommentsTests*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Text.Json.Tests.Utf8JsonReaderCommentsTests.Utf8JsonReaderCommentParsing(CommentHandling: Allow, SegmentSize: 100, TestCase: ShortMultiLine)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 125.64555176494972 > 124.44072644704792.
IsChangePoint: Marked as a change because one of 9/6/2022 1:06:44 PM, 10/25/2022 2:34:53 PM, 10/31/2022 4:38:04 PM, 11/8/2022 2:29:58 AM falls between 10/30/2022 12:44:54 AM and 11/8/2022 2:29:58 AM.
IsRegressionStdDev: Marked as regression because -38.33955249148411 (T) = (0 -125.32261968017002) / Math.Sqrt((0.46385682761922326 / (19)) + (0.10030479256099278 / (11))) is less than -2.048407141790485 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (11) - 2, .025) and -0.05934521179082898 = (118.30196453931333 - 125.32261968017002) / 118.30196453931333 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS Windows 10.0.19042
Baseline 3d9d78c63c5ad9a2ed15b2c863f989a8cef2a8b9
Compare 7d5efbb9e10b6d8beb91c90cbdefd7360869cece
Diff Diff

Regressions in System.Reflection.Attributes

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
GetCustomAttributesMethodBaseMiss - Duration of single invocation 95.20 ns 104.16 ns 1.09 0.18 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Reflection.Attributes*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Reflection.Attributes.GetCustomAttributesMethodBaseMiss


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 104.16145969229643 > 100.99511405628034.
IsChangePoint: Marked as a change because one of 9/7/2022 8:07:21 PM, 9/21/2022 6:35:49 PM, 10/5/2022 3:48:29 AM, 10/31/2022 4:38:04 PM, 11/8/2022 2:29:58 AM falls between 10/30/2022 12:44:54 AM and 11/8/2022 2:29:58 AM.
IsRegressionStdDev: Marked as regression because -14.200214792235771 (T) = (0 -113.3940775046906) / Math.Sqrt((9.674897636475949 / (19)) + (19.947002015221376 / (29))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (29) - 2, .025) and -0.15876422352425795 = (97.85776536991675 - 113.3940775046906) / 97.85776536991675 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant