Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugs and potential improvements for perf-autofiling-issues #2975

Closed
2 of 4 tasks
kotlarmilos opened this issue Apr 20, 2023 · 4 comments
Closed
2 of 4 tasks

Minor bugs and potential improvements for perf-autofiling-issues #2975

kotlarmilos opened this issue Apr 20, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@kotlarmilos
Copy link
Member

kotlarmilos commented Apr 20, 2023

Description

Here are some thoughts on observed minor bugs and potential improvements for perf-autofiling-issues:

  • The Baseline, Test, and Test/Base columns are likely the most frequently used. Any empty columns could be either removed or utilized for additional relevant information. Also, it would be helpful to provide a brief explanation in the issues of what the Test Quality and Edge Detector columns represent.
  • The benchmark names could be more descriptive. Adding a class or arguments to the benchmark function name would be helpful. #3124
  • The images displayed below the table should match the microbenchmarks listed in the table. In the current example, one image is missing. Additionally, when clicking on an image, a different image is displayed. This should be fixed to display the correct/same image.
  • Benchmark links don't work on Mono runtimes

Screenshot 2023-04-20 at 11 49 24

dotnet/perf-autofiling-issues#16372

@kotlarmilos kotlarmilos added the bug Something isn't working label Apr 20, 2023
@cincuranet
Copy link
Contributor

cincuranet commented Apr 20, 2023

The images problem is tracked here #2957 and I'll fix it this/next week.

@cincuranet
Copy link
Contributor

cincuranet commented Jun 30, 2023

@kotlarmilos Can you elaborate on "Benchmark links don't work on Mono runtimes"? Never mind, found it.

@cincuranet
Copy link
Contributor

Benchmark links should be now fixed. If you still see, @kotlarmilos, some configuration combination that's not working, let me know.

@kotlarmilos
Copy link
Member Author

Hey @cincuranet I missed your previous comment, sorry. Good, thanks! Feel free to close this issue if done.

I will collect the feedback from the team and we may open another issue for potential improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants