From b69e2204353cc430e6bb28b43879c7165e161dd3 Mon Sep 17 00:00:00 2001 From: Shen Chen Date: Fri, 5 Mar 2021 10:11:53 -0800 Subject: [PATCH 1/2] remove the word crazy --- .../GenerateConstructor/GenerateConstructorHelpers.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs b/src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs index d2132e9b5536d..65c3d518e0e32 100644 --- a/src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs +++ b/src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs @@ -97,7 +97,7 @@ private static bool IsCompatible( // However, theoretically the public type from A could have a user-defined conversion. // The alternative approach might be to map the type of the parameters back into B, and then // classify the conversions in Project B, but that'll run into other issues if the experssions - // don't have a natural type (like default). We choose to ignore all potentially crazy cases here. + // don't have a natural type (like default). We choose to ignore all potentially cases here. return false; } From 45aa3370a170c986b6fa8ab8946fcf36cb5a79e4 Mon Sep 17 00:00:00 2001 From: Shen Chen Date: Fri, 5 Mar 2021 10:53:39 -0800 Subject: [PATCH 2/2] Update src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs Co-authored-by: Jason Malinowski --- .../GenerateConstructor/GenerateConstructorHelpers.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs b/src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs index 65c3d518e0e32..48b299a76edc6 100644 --- a/src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs +++ b/src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs @@ -97,7 +97,7 @@ private static bool IsCompatible( // However, theoretically the public type from A could have a user-defined conversion. // The alternative approach might be to map the type of the parameters back into B, and then // classify the conversions in Project B, but that'll run into other issues if the experssions - // don't have a natural type (like default). We choose to ignore all potentially cases here. + // don't have a natural type (like default). We choose to ignore all complicated cases here. return false; }