Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests that assert modreq breaking support for native csc/vbc #19909

Open
OmarTawfik opened this issue May 31, 2017 · 3 comments
Open

Write tests that assert modreq breaking support for native csc/vbc #19909

OmarTawfik opened this issue May 31, 2017 · 3 comments
Labels
Area-Compilers New Language Feature - Readonly References Readonly References Test Test failures in roslyn-CI
Milestone

Comments

@OmarTawfik
Copy link
Contributor

We're using modreqs to prevent other/older compilers from consuming/extending ref-readonly symbols in a non-safe way.
There is already some tests being added on VB side to assert that behavior, but we need to write [WindowsOnly] tests that call the csc/vbc on the machine (the native compilers) and assert they exhibit the right behavior as well.

See #17287 for more details

@OmarTawfik OmarTawfik added New Language Feature - Readonly References Readonly References Test Test failures in roslyn-CI labels May 31, 2017
@jcouv
Copy link
Member

jcouv commented Jun 7, 2017

I'm not sure what is the value of writing such test automation. Shouldn't it be good enough to verify once (possibly against different versions of the compiler)? Those shipped compilers are not expected to change.

@jcouv jcouv added this to the 15.6 milestone Jun 7, 2017
@OmarTawfik
Copy link
Contributor Author

@jcouv manual verification was done. But I want to have this sort of automation in case a regression happened in the way the current version writes out modreqs. This is not a high-pri though.

@tannergooding
Copy link
Member

This should probably be an outer loop test.

It should also probably be added to the list of manual checks done prior to release.

@VSadov VSadov modified the milestones: 15.5, 15.later Sep 14, 2017
@OmarTawfik OmarTawfik modified the milestones: 15.later, 15.5 Sep 20, 2017
@OmarTawfik OmarTawfik removed their assignment Sep 22, 2017
@jaredpar jaredpar modified the milestones: 15.6, 15.7 Jan 4, 2018
@jaredpar jaredpar modified the milestones: 15.7, 16.0 Aug 22, 2018
@gafter gafter added this to the Backlog milestone Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers New Language Feature - Readonly References Readonly References Test Test failures in roslyn-CI
Projects
None yet
Development

No branches or pull requests

7 participants