Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of Deconstruct #24413

Closed
aobatact opened this issue Jan 24, 2018 · 3 comments
Closed

Description of Deconstruct #24413

aobatact opened this issue Jan 24, 2018 · 3 comments
Assignees
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@aobatact
Copy link

aobatact commented Jan 24, 2018

Version Used:
15.5.2
8
10

Currently what ever object is deconstructed, it shows the description of deconstructing ValueTuple.

@jcouv
Copy link
Member

jcouv commented Jan 24, 2018

@aobatact Can you clarify what you expected?

@jcouv jcouv added the Area-IDE label Jan 24, 2018
@aobatact
Copy link
Author

I expect that it shows what type it is deconstructed and what parameter it is deconstructed.
If we can, it might be better to show the param in the XML Document.
For example

struct IntTuple
{
    int x;
    int y;
    /// <summary>
    /// Deconstruction of <see cref="IntTuple"/>
    /// </summary>
    /// <param name="x">Gets the value of the current <see cref="IntTuple"/> instance's first element.</param>
    /// <param name="y">Gets the value of the current <see cref="IntTuple"/> instance's second element.</param>
    public void Deconstruct(out int x,out int y)
    {
        x = this.x;
        y = this.y;
    }
}

If there is some custom Deconstruct method like this and if we point the first Deconstructed parametor, it should show "Gets the value of the current IntTuple instance's first element.".

@jinujoseph jinujoseph added the Bug label Jan 29, 2018
@jinujoseph jinujoseph added this to the Unknown milestone Jan 29, 2018
@jinujoseph jinujoseph added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Jan 29, 2018
@jcouv
Copy link
Member

jcouv commented Feb 14, 2018

Relates to #16529

@jcouv jcouv self-assigned this Apr 6, 2018
@jcouv jcouv modified the milestones: Unknown, 15.8 Apr 6, 2018
@jcouv jcouv added the 4 - In Review A fix for the issue is submitted for review. label Apr 6, 2018
@jinujoseph jinujoseph removed the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Apr 6, 2018
@jinujoseph jinujoseph added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

3 participants