Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyTypeCustomModifiers() should copy NativeIntegerAttribute values #42500

Closed
cston opened this issue Mar 17, 2020 · 1 comment · Fixed by #47536
Closed

CopyTypeCustomModifiers() should copy NativeIntegerAttribute values #42500

cston opened this issue Mar 17, 2020 · 1 comment · Fixed by #47536
Assignees
@cston
Labels
Area-Compilers Bug New Language Feature - Native Int
Milestone
16.8

Comments

@cston
Copy link
Member

cston commented Mar 17, 2020

CustomModifierUtils.CopyTypeCustomModifiers() should copy NativeIntegerAttribute values.

See #42419 (comment), #42419 (comment).
@cston cston mentioned this issue Mar 17, 2020
Merged
@AlekseyTs
Copy link
Contributor

The assert at the end of the method should also be adjusted:

Debug.Assert(resultType.Equals(destinationType, TypeCompareKind.IgnoreCustomModifiersAndArraySizesAndLowerBounds)); // Same object/dynamic, nullability and tuple names as destination type.

@cston cston added this to the Compiler.Net5 milestone Apr 7, 2020
@jaredpar jaredpar modified the milestones: Compiler.Net5, 16.8 Jun 23, 2020
@cston cston mentioned this issue Sep 8, 2020
Merged
@jcouv jcouv assigned jcouv and unassigned jcouv Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cston cston

Labels
Area-Compilers Bug New Language Feature - Native Int
Projects
None yet
Milestone
16.8
Development

Successfully merging a pull request may close this issue.

Consider NativeIntegerAttribute in CopyTypeCustomModifiers() cston/roslyn
4 participants
@jaredpar @AlekseyTs @cston @jcouv