-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A change in a top-level statement or an addition of a new top-level statement is not picked up by ENC #44196
Comments
No top-level code edits will work without explicit support for the feature in Edit and Continue impl. It is also possible that EnC is broken when editing non-top-level code (e.g. a top-level class) when top-level code is present. This will need both compiler and IDE work. |
Indeed, editing regular code in the file with top-level statements has the same issue. |
@tmat It is quite possible that EnC is broken for RoslynDeployment. I ran into similar issues with a program that doesn't have top-level statements. |
Just occurred to me... are you using master-vs-deps? EnC does not work in master since it requires the latest VS bits. |
No, I am trying bits from features/SimplePrograms branch, which is almost up to date with master. |
That explains. For end-to-end testing you'd need 1) branch off of master-vs-deps 2) make changes in the IDE to support statement diffing in top-level code. |
@tmat Just an FYI, the feature has been merged into master |
Thanks! |
We are looking at expanding hot reload to support changes to an ASP.NET Core's bootstrapping code. Starting in 6.0, we're going to push a minimal hosting solution that relies on top level statements - dotnet/aspnetcore#30354. Fixing this would unblock this scenario. FYI @davidfowl |
Debugger simply ignores new code afterwards. It is quite possible that "rude" edits detection isn't quite working.
Relates to #43563 (test plan for "top-level statements")
The text was updated successfully, but these errors were encountered: