Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ConditionalFact(typeof(x86)) #462

Closed
jaredpar opened this issue Feb 13, 2015 · 4 comments · Fixed by #52538
Closed

Remove ConditionalFact(typeof(x86)) #462

jaredpar opened this issue Feb 13, 2015 · 4 comments · Fixed by #52538

Comments

@jaredpar
Copy link
Member

PR #453 enabled the running of our tests in 64 bit by adding the /p:Test64=true option to BuildAndTest.proj

msbuild /v:m /m BuildAndTest.proj /p:Test64=true

In order to do this a number of tests were disabled by adding a Fact annotation that disabled the test in 64 bit runs.

// C#
[ConditionalFact(typeof(x86))]
' Visual Basic
<ConditionalFact(GetType(x86))>

These attributes all represent bugs in our test environment, and potentially production code, that need to be fixed up. This bug tracks removing all of these and getting the tests working on 64 bit.

Note: This does not include the uses of the above attributes in the Visual Studio directory.

@jaredpar jaredpar assigned jaredpar and KevinH-MS and unassigned jaredpar Feb 13, 2015
@DustinCampbell
Copy link
Member

Note that it might be possible to remove the <ConditionalFact(GetType(x86))> from the Visual Studio directory. This was originally added because we had a native binary to handle COM aggregation. However, now we do that in some very... ummm... disorienting managed code that implements VTable and COM Aggregation logic. So, the dependency on x86 may no longer be necessary.

@ManishJayaswal
Copy link
Contributor

Let's get this fixed area by area. Kevin once you are done with debugger area, assign this to someone in another feature team who have fix up work to do and update the label.

@ManishJayaswal ManishJayaswal modified the milestones: 1.2, 1.1 Sep 17, 2015
@davkean
Copy link
Member

davkean commented Oct 21, 2015

Removing infrastructure, these are test bugs against product areas.

@ManishJayaswal ManishJayaswal modified the milestones: 1.3, 1.2 Jan 27, 2016
@ManishJayaswal ManishJayaswal modified the milestones: 1.3, 2.0 (RC) May 6, 2016
@ManishJayaswal ManishJayaswal modified the milestones: 2.0 (RC), 2.1 Oct 14, 2016
@jinujoseph jinujoseph modified the milestones: 15.1, 15.later May 22, 2017
@jinujoseph jinujoseph removed this from the 15.1 milestone May 22, 2017
@jinujoseph jinujoseph modified the milestones: 15.6, Unknown Nov 3, 2017
@Youssef1313
Copy link
Member

Related to: #28639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants