Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion tests fail after updating Editor to 16.8.181 #48870

Closed
tmat opened this issue Oct 23, 2020 · 4 comments
Closed

Completion tests fail after updating Editor to 16.8.181 #48870

tmat opened this issue Oct 23, 2020 · 4 comments
Assignees
@genlu
Labels
Area-IDE IDE-IntelliSense Completion, Signature Help, Quick Info Test Test failures in roslyn-CI
Milestone
16.9

Comments

@tmat
Copy link
Member

tmat commented Oct 23, 2020 •
edited
Loading

See test results https://dev.azure.com/dnceng/public/_build/results?buildId=863202&view=ms.vss-test-web.build-test-results-tab&runId=27649786&resultId=166437&paneView=debug for #48866.

Blocking move of EditorFeatures.Cocoa to Roslyn
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 23, 2020
@tmat tmat added Area-IDE IDE-IntelliSense Completion, Signature Help, Quick Info and removed Area-Infrastructure labels Oct 23, 2020
@tmat tmat changed the title Completion test fail after updating Editor to 16.8.181 Completion tests fail after updating Editor to 16.8.181 Oct 23, 2020
@sharwell
Copy link
Member

Can we not downgrade the EditorFeatures.Cocoa reference, and allow consuming parties to use something newer?

@tmat
Copy link
Member Author

tmat commented Oct 23, 2020

EditorFeatures.Cocoa depends on Microsoft.VisualStudio.Text.UI.Cocoa and the lowest available version of that package is 16.8.181.

@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 26, 2020
@jinujoseph jinujoseph added this to the 16.9 milestone Oct 26, 2020
@genlu
Copy link
Member

genlu commented Oct 26, 2020

Seems the common theme of failed tests involves moving cursor before initial trigger char. I tried to debug and it seems this is handled by editor. Chatting with @AmadeusW offline to confirm

@jinujoseph jinujoseph added the Test Test failures in roslyn-CI label Oct 27, 2020
@genlu
Copy link
Member

genlu commented Nov 5, 2020

Fix in VS is here, should be available soon
https://devdiv.visualstudio.com/DevDiv/_git/d9dc88ef-476f-4add-967b-f7ddd47f4b71/pullrequest/285872

@genlu genlu mentioned this issue Nov 9, 2020
Merged
@genlu genlu closed this as completed Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genlu genlu

Labels
Area-IDE IDE-IntelliSense Completion, Signature Help, Quick Info Test Test failures in roslyn-CI
Projects
None yet
Milestone
16.9
Development

No branches or pull requests
5 participants
@tmat @genlu @sharwell @jinujoseph @Dotnet-GitSync-Bot