Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reference and the reference count refers to the method name and not the method of the object #49288

Closed
vsfeedback opened this issue Nov 11, 2020 · 2 comments
Labels
Area-IDE Concept-Continuous Improvement Developer Community The issue was originally reported on https://developercommunity.visualstudio.com IDE-Navigation Navigation and search Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


PLease refer to the screen shot
! [image.png] (https://aka.ms/dc/image?name=B7ed70c396d4c402d91e3298813e268f3637405786012071813_20201110-121536-image.png&tid=7ed70c396d4c402d91e3298813e268f3637405786012071813)
Clearly the reference EBSTypes should not be linked to the ToString() of the SyncMajorInfo object. It is sometime useful to see where this is used and the 'rename' should also impact only the variable of that object and not doing a blind text replace.


Original Comments

Feedback Bot on 11/10/2020, 00:49 AM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

C. Hannosset on 11/10/2020, 01:50 AM:

“The reference and the reference count refers to the method name and not the method of the object”
Well obviously it does indeed, but reference count to the method name only and not the method of the object is not very helpful in some cases. This is then not a ‘bug’ but could this be shifted for an improvement? I am sure this will be welcomed.


Original Solutions

(no solutions)

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 11, 2020
@jinujoseph jinujoseph added Concept-Continuous Improvement Developer Community The issue was originally reported on https://developercommunity.visualstudio.com and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 17, 2020
@jinujoseph jinujoseph added this to the Backlog milestone Nov 17, 2020
@jinujoseph jinujoseph added the IDE-Navigation Navigation and search label Nov 17, 2020
@sharwell
Copy link
Member

sharwell commented Nov 17, 2020

I believe the rename behavior is already correct. The CodeLens references may benefit from limiting the coalescing to only include definitions from base and derived types, and filter references are statically known to not be resolvable to the current overload.

/cc @CyrusNajmabadi

@CyrusNajmabadi
Copy link
Member

Fixed with #51637. CodeLens was updated as part of that as well.

@CyrusNajmabadi CyrusNajmabadi added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement Developer Community The issue was originally reported on https://developercommunity.visualstudio.com IDE-Navigation Navigation and search Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

5 participants