Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: It is possible to emit invalid delta if semantic info is inferred from documents that are not up to date #51261

Open
tmat opened this issue Feb 17, 2021 · 0 comments

Comments

@tmat
Copy link
Member

tmat commented Feb 17, 2021

Semantic EnC analysis of documents that contain partial types or types moved across documents examines semantic information from the base project compilation.
Based on this information it may infer that a type does not exist in the base compilation but that type could be declared in a document that's out of date. As a result, the analysis may produce an insert edit for a type that already already exists in the compilation.

Possible solution would be to look up symbols from the baseline metadata for the first generation update in addition to the base source compilation (last committed solution).
Types can't be removed by EnC and therefore if the type exists in the baseline metadata it must exist in the base source compilation if it was up to date.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 17, 2021
@tmat tmat self-assigned this Feb 17, 2021
@tmat tmat added this to the 16.10 milestone Feb 17, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 17, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, Backlog Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants