Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add the usings for System.Threading.Tasks in the "Make method async refactoring" #51354

Closed
jmarolf opened this issue Feb 20, 2021 · 1 comment · Fixed by #51469
Closed

Automatically add the usings for System.Threading.Tasks in the "Make method async refactoring" #51354

jmarolf opened this issue Feb 20, 2021 · 1 comment · Fixed by #51469
Assignees
@davidwengier
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Milestone
16.10

Comments

@jmarolf
Copy link
Contributor

jmarolf commented Feb 20, 2021

I use this refactoring a lot, but it always fully-qualifies the Tasks type if I don't have the using in scope

image

This means I always need to delete the fully qualified name and invoke the second "Add using" codefix.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 20, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 24, 2021
@jinujoseph jinujoseph added this to the Backlog milestone Feb 24, 2021
@sharwell
Copy link
Member

📝 This is as easy as adding Simplifier.AddImportsAnnotation to the generated syntax node in the existing code fix.

@jinujoseph jinujoseph modified the milestones: Backlog, 16.10 Feb 24, 2021
@Youssef1313 Youssef1313 mentioned this issue Feb 25, 2021
Merged
@LukasGelke LukasGelke mentioned this issue Mar 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Projects
None yet
Milestone
16.10
Development

Successfully merging a pull request may close this issue.

Add 'AddImportsAnnotation' Youssef1313/roslyn
4 participants
@davidwengier @sharwell @jmarolf @jinujoseph