Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make class abstract doesn't preserve modifiers #54218

Closed
Youssef1313 opened this issue Jun 18, 2021 · 0 comments · Fixed by #54905
Closed

Make class abstract doesn't preserve modifiers #54218

Youssef1313 opened this issue Jun 18, 2021 · 0 comments · Fixed by #54905
Assignees
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@Youssef1313
Copy link
Member

Version Used:

main

Steps to Reproduce:

Apply make abstract codefix.

partial class C
{
}

partial class C
{
    protected abstract void M();
}

Expected Behavior:

abstract is added and partial is kept.

partial class C
{
}

partial abstract class C
{
    protected abstract void M();
}

Actual Behavior:

partial is removed

partial class C
{
}

abstract class C
{
    protected abstract void M();
}

Note: Fix could be similar to #54216.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 18, 2021
@jinujoseph jinujoseph added Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 14, 2021
@jinujoseph jinujoseph added this to the Backlog milestone Jul 14, 2021
@jinujoseph jinujoseph added 4 - In Review A fix for the issue is submitted for review. and removed help wanted The issue is "up for grabs" - add a comment if you are interested in working on it labels Jul 19, 2021
@jinujoseph jinujoseph modified the milestones: Backlog, 17.0 Jul 19, 2021
@jinujoseph jinujoseph added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants