Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental C# LSP Completions committed with overtypeable characters don't overtype #55187

Closed
NTaylorMullen opened this issue Jul 28, 2021 · 3 comments
Closed

Experimental C# LSP Completions committed with overtypeable characters don't overtype #55187

NTaylorMullen opened this issue Jul 28, 2021 · 3 comments
Assignees
@allisonchou
Labels
Area-IDE Bug LSP issues related to the roslyn language server protocol implementation
Milestone
17.3

Comments

@NTaylorMullen
Copy link
Contributor

Version Used:
image

Steps to Reproduce:

  1. Enable C#'s LSP editor + preview completion:
    image
  2. In a C# file type each character if (tru, you'll end up with if (tru| and a completion list highlighting true
  3. Commit the true completion item with )

Repro:
aJ8HUXNXWB

Expected Behavior: if (true)|

Actual Behavior: if (true|
@NTaylorMullen NTaylorMullen added Bug Area-IDE LSP issues related to the roslyn language server protocol implementation labels Jul 28, 2021
@NTaylorMullen NTaylorMullen added this to the 17.0 milestone Jul 28, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 28, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement 4 - In Review A fix for the issue is submitted for review. and removed untriaged Issues and PRs which have not yet been triaged by a lead Concept-Continuous Improvement 4 - In Review A fix for the issue is submitted for review. labels Jul 28, 2021
@jinujoseph
Copy link
Contributor

#55252 turning off the feature in 17.0.preview3

@NTaylorMullen
Copy link
Contributor Author

After fixing this we should validate if it fixes this issue: https://github.com/dotnet/aspnetcore/issues/34820

Turning off the experimental C# completions ended up resolving the provisional completion issue for me

@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Sep 13, 2021
@allisonchou allisonchou modified the milestones: 17.1, 17.2 Jan 7, 2022
@allisonchou allisonchou modified the milestones: 17.2, 17.3 Mar 16, 2022
@allisonchou
Copy link
Contributor

The aforementioned feature flag is no longer applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allisonchou allisonchou

Labels
Area-IDE Bug LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
17.3
Development

No branches or pull requests
3 participants
@NTaylorMullen @jinujoseph @allisonchou