Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some lookup diagnostics may be missed when a file type shadows a non-file type #62331

Open
RikkiGibson opened this issue Jul 1, 2022 · 0 comments
Assignees
Milestone

Comments

@RikkiGibson
Copy link
Contributor

Related to #61500, #60819

if (best.IsFromFile && !secondBest.IsFromFile)
{
// a lookup of a file type is "better" than a lookup of a non-file type; no need to further diagnose
// PROTOTYPE(ft): some "single symbol" diagnostics are missed here for similar reasons
// that make us miss diagnostics when reporting WRN_SameFullNameThisAggAgg.
//
return first;
}

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 1, 2022
@RikkiGibson RikkiGibson added the New Language Feature - File-Local Types File-local types (file types) label Jul 1, 2022
@jcouv jcouv added this to the 17.4 milestone Jul 5, 2022
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 5, 2022
@jaredpar jaredpar added the Bug label Jul 8, 2022
@jaredpar jaredpar modified the milestones: 17.4, 17.5 Oct 7, 2022
@jaredpar jaredpar modified the milestones: 17.5, 17.6 Jan 5, 2023
@jaredpar jaredpar modified the milestones: 17.6, Backlog Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants