Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB EnC rename tests are failing in CI #62844

Closed
CyrusNajmabadi opened this issue Jul 21, 2022 · 6 comments
Closed

VB EnC rename tests are failing in CI #62844

CyrusNajmabadi opened this issue Jul 21, 2022 · 6 comments
Assignees
@davidwengier
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@CyrusNajmabadi
Copy link
Member

The following tests are failing:

Test	Duration
Microsoft.CodeAnalysis.VisualBasic.EditAndContinue.UnitTests.TopLevelEditingTests.PropertyRename1 Failed	4 ms
Project: Microsoft.CodeAnalysis.VisualBasic.EditorFeatures.UnitTests Failed (6)	2.1 sec
Namespace: Microsoft.CodeAnalysis.VisualBasic.EditAndContinue.UnitTests Failed (6)	2.1 sec
Class: TopLevelEditingTests Failed (6)	2.1 sec
Microsoft.CodeAnalysis.VisualBasic.EditAndContinue.UnitTests.TopLevelEditingTests.Event_Rename Failed	16 ms
Microsoft.CodeAnalysis.VisualBasic.EditAndContinue.UnitTests.TopLevelEditingTests.EventInsert_IntoLayoutClass_Sequential Failed	266 ms
Microsoft.CodeAnalysis.VisualBasic.EditAndContinue.UnitTests.TopLevelEditingTests.Method_Rename Failed	7 ms
Microsoft.CodeAnalysis.VisualBasic.EditAndContinue.UnitTests.TopLevelEditingTests.PartialMember_RenameInsertDelete Failed	52 ms
Microsoft.CodeAnalysis.VisualBasic.EditAndContinue.UnitTests.TopLevelEditingTests.PropertyRename2 Failed	1.8 sec
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 21, 2022
@CyrusNajmabadi
Copy link
Member Author

Disabled in #62833

@Youssef1313
Copy link
Member

@davidwengier fwiw, I ran the test on the branch from the PR (got it via gh pr checkout 62364) and it still failed locally. It's very strange this passed CI in first place.

@CyrusNajmabadi
Copy link
Member Author

@RikkiGibson @allisonchou ^ Very concerning. We may have CI hole here.

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Jul 21, 2022 •
edited
Loading

It would be useful to know if the test failures are observed locally when running .\Build.cmd -test, or if they are only observed in e.g. Test Explorer or dotnet test.

@davidwengier
Copy link
Contributor

Sorry! I blindly trust GitHub to not let me merge if things go bad.

Looks like my last commit/push didn't kick off a build for some reason.

@RikkiGibson
Copy link
Contributor

Fixed by #62843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davidwengier @CyrusNajmabadi @RikkiGibson @Youssef1313