Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit if new APIs added to IFileChangeWatcher.cs were intentionally public or not #65738

Closed
mavasani opened this issue Dec 3, 2022 · 1 comment
Assignees
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@mavasani
Copy link
Contributor

mavasani commented Dec 3, 2022

@jasonmalinowski It seems the correctness analyzers leg is failing as you recently added a public API that has no entry in unshipped file:

src/Workspaces/Core/Portable/Workspace/ProjectSystem/IFileChangeWatcher.cs(26,25): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'WatchedDirectory' is not part of the declared public API

Looking at your PR which added this public API: #65701, it seems the public API addition was likely unintentional. I am going to to switch it to an internal type, and feel free to make it public again if that was an intentional change.

EDIT: It seems #65701 added 2 more public interfaces: IFileChangeContext and IWatchedFile. I am not sure if any of them were intentionally made public. I have switched all of them back to internal.

Originally posted by @mavasani in #65737 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 3, 2022
@mavasani mavasani changed the title Audit if new APIs added to IFileChangeWatcher.cs are intended to make public or not Audit if new APIs added to IFileChangeWatcher.cs were intentionally public or not Dec 3, 2022
@jasonmalinowski
Copy link
Member

None of these were intended to be made public, so thank you this was a very good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

No branches or pull requests

2 participants