Add Imports not offered after first submission

[amcasey]

1. #r "System.Xml"
2. typeof(ArrayList)

Expected: Lightbulb offering to import System.Collections
Actual: No lightbulb

[amcasey]

Note that it works before the #r and it resumes working after #reset.

[amcasey]

FYI @kuhlenh @ManishJayaswal @jmarolf @tmat

[amcasey]

The compilation in which we are looking for the symbol has 45 ReferencedAssemblyNames but 0 References.

[amcasey]

The underlying reference manager has 0 DirectiveReferences, 39 ImplicitReferences, and 7 ExplicitReferences.

[amcasey]

The compilation has 0 ExternalReferences - that seems to be what's getting dropped.

[amcasey]

Since the intention of Compilation.References seems to be to return references explicitly added via either compilation options or #r, it seems strange that it isn't just returning GetBoundReferenceManager().ExplicitReferences. There doesn't seem to be a performance advantage since retrieving the DirectiveReferences triggers binding of the reference manager anyway.

[amcasey]

That change appears to have fixed this particular issue. I'll run the tests to try to figure out what it breaks.

[tmat]

I introduced ExplicitReferences just recently, for ask mode, so I haven't had a chance to do more cleanup, which would indeed be nice.

[amcasey]

Unit tests are green on my box. Shall I create a PR?

[ManishJayaswal]

@tmat let's investigate the fix here. We should take this fix to shiproom - ideally tomorrow at 1p

[amcasey]

To be explicit: I'm pretty sure my change is just masking the problem.

[amcasey]

I'll keep investigating, but this really needs @tmat's input.

[tmat]

Looking

[amcasey]

@tmat pointed out that it doesn't just fail after #r - it fails anywhere other than the first submission after a reset.

[amcasey]

Please unskip the flagged IDE test when this is fixed.

[amcasey]

Does the scenario described in this issue work now? Or has it become moot?