Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection expressions: additional implicit conversions from builder return value are not included in semantic model #69938

Closed
cston opened this issue Sep 13, 2023 · 2 comments
Closed

Collection expressions: additional implicit conversions from builder return value are not included in semantic model #69938

cston opened this issue Sep 13, 2023 · 2 comments
Assignees
@cston
Labels
Area-Compilers Bug New Feature - Collection Expressions
Milestone
17.9

Comments

@cston
Copy link
Member

cston commented Sep 13, 2023

The additional implicit conversion (converting from the return value of a collection expression builder method to the expected target type) is not included in the semantic model.

The implicit conversion is currently stored in BoundCollectionExpression.CollectionBuilderInvocationConversion and only used by lowering.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 13, 2023
@cston cston mentioned this issue Sep 13, 2023
Closed
@jaredpar
Copy link
Member

Is this critical for .NET 8 or puntable post .NET 8

@cston cston added this to the 17.9 milestone Sep 26, 2023
@jcouv jcouv added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 4, 2023
@cston
Copy link
Member Author

cston commented Nov 8, 2023

The implicit conversion is only meaningful for IOperation. Resolving as duplicate of IOperation API proposal: #70631.

@cston cston closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cston cston

Labels
Area-Compilers Bug New Feature - Collection Expressions
Projects
None yet
Milestone
17.9
Development

No branches or pull requests
3 participants
@jaredpar @cston @jcouv