Trim away netframework targets in source-build #67384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Community
|
I think we need to understand why this needs to be backported. |
.NET 8 picks up Roslyn from cc @mmitche |
|
Then we will likely have to wait for the next snap (when this branch will become P3). I don't think we can take this change in this branch currently. |
When is the next snap supposed to happen? We could wait up to a week I think, otherwise we'd need to think of alternatives. |
|
I'm not sure. Hopefully someone from @dotnet/roslyn-infrastructure can answer. |
|
If this doesn't impact VS build we may be okay here. |
Yeah, this change is for Linux and source-build only. |
mmitche
approved these changes
Mar 22, 2023
allisonchou
approved these changes
Mar 22, 2023
|
@allisonchou can this be merged manually? 3 CI legs are failing, and auto-merge will not get triggered. All failing CI legs are running on Windows. My changes are Linux source-build specific and do not affect Windows build. Same CI legs are failing in other PRs, i.e. #67279 |
|
@NikolaMilosavljevic I'm noticing a correctness build error that isn't present in the other PR you linked:
Does this seem like it could be related to your changes? |
No. My changes are in |
|
I'm going to close/reopen to force rebase and rerun of checks. |
|
Note that you can do this with |
Yeah, I've used those in the past. The goal was to rebase the change, to see if we pick up any potential fixes from the target branch. I still don't understand why |
The run commands do that too. @RikkiGibson the logs are showing this assert, does it look familiar? |
@RikkiGibson @333fred @mmitche what are the next steps here? Changes in |
|
Follow-up to #67384 (comment) I compared this with recent builds on the branch: https://dev.azure.com/dnceng-public/public/_build?definitionId=95&_a=summary&branchFilter=14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360%2C14360 It looks like both the rolling builds of release/dev17.6 still retained in our logs have the same failure. I think we should file an issue for this (unless we already have one @Cosifne @allisonchou?) I recommend force merging this PR. |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #67355
### Summary of the changes
This is part of the source-build work to enable trimming of net4* targets. Parent repos (
installerandsdk) have been updated, so the next step is to update dependencies, likeroslyn.Here's how this is consumed: dotnet/arcade#12785
Top-level tracking issue: dotnet/source-build#3014
This essentially just avoids building net4* TFMs when building Linux source build.
Fixes: #63746