From ddd0a13e1cfd77cb9bf3924efcb4f41120542161 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Fri, 23 Jun 2023 22:10:04 -0500 Subject: [PATCH] remove long gone owners --- src/Compilers/Core/MSBuildTask/CanonicalError.cs | 4 ---- src/Compilers/Core/MSBuildTask/Csc.cs | 3 --- src/Compilers/Core/MSBuildTask/ManagedCompiler.cs | 2 -- src/Compilers/Core/MSBuildTask/Vbc.cs | 3 --- 4 files changed, 12 deletions(-) diff --git a/src/Compilers/Core/MSBuildTask/CanonicalError.cs b/src/Compilers/Core/MSBuildTask/CanonicalError.cs index e00471737bae2..1665fe561adf6 100644 --- a/src/Compilers/Core/MSBuildTask/CanonicalError.cs +++ b/src/Compilers/Core/MSBuildTask/CanonicalError.cs @@ -48,7 +48,6 @@ namespace Microsoft.CodeAnalysis.BuildTasks /// /// <text> : warning [num]: <msg> /// - /// JomoF internal static class CanonicalError { // Defines the main pattern for matching messages. @@ -141,7 +140,6 @@ internal static class CanonicalError /// /// Represents the parts of a decomposed canonical message. /// - /// JomoF internal sealed class Parts { /// @@ -237,7 +235,6 @@ internal Parts() /// /// /// 'value' converted to int or 0 if it can't be parsed or is negative - /// LukaszG private static int ConvertToIntWithDefault(string value) { int result; @@ -255,7 +252,6 @@ private static int ConvertToIntWithDefault(string value) /// Decompose an error or warning message into constituent parts. If the message isn't in the canonical form, return null. /// /// This method is thread-safe, because the Regex class is thread-safe (per MSDN). - /// JomoF /// /// Decomposed canonical message, or null. internal static Parts? Parse(string message) diff --git a/src/Compilers/Core/MSBuildTask/Csc.cs b/src/Compilers/Core/MSBuildTask/Csc.cs index 9a7d8cbc51277..ea3fd91183d84 100644 --- a/src/Compilers/Core/MSBuildTask/Csc.cs +++ b/src/Compilers/Core/MSBuildTask/Csc.cs @@ -459,7 +459,6 @@ internal static void AddReferencesToCommandLine( /// thing for csc.exe, the IDE compiler cannot support it. In this situation /// the return value will also be false. /// - /// RGoel private bool InitializeHostCompiler(ICscHostObject cscHostObject) { bool success; @@ -659,7 +658,6 @@ private bool InitializeHostCompiler(ICscHostObject cscHostObject) /// NoActionReturnSuccess Host compiler was already up-to-date, and we're done. /// NoActionReturnFailure Bad parameters were passed into the task. /// - /// RGoel protected override HostObjectInitializationStatus InitializeHostObject() { if (HostObject != null) @@ -746,7 +744,6 @@ protected override HostObjectInitializationStatus InitializeHostObject() /// This method will get called during Execute() if a host object has been passed into the Csc /// task. Returns true if the compilation succeeded, otherwise false. /// - /// RGoel protected override bool CallHostObjectToExecute() { Debug.Assert(HostObject != null, "We should not be here if the host object has not been set."); diff --git a/src/Compilers/Core/MSBuildTask/ManagedCompiler.cs b/src/Compilers/Core/MSBuildTask/ManagedCompiler.cs index 8d9a20a76aa33..fd7584f390acb 100644 --- a/src/Compilers/Core/MSBuildTask/ManagedCompiler.cs +++ b/src/Compilers/Core/MSBuildTask/ManagedCompiler.cs @@ -1142,7 +1142,6 @@ protected bool HostCompilerSupportsAllParameters /// support a particular parameter or variation on a parameter. So we log a comment, /// and set our state so we know not to call the host object to do the actual compilation. /// - /// RGoel protected void CheckHostObjectSupport ( string parameterName, @@ -1172,7 +1171,6 @@ internal void InitializeHostObjectSupportForNewSwitches(ITaskHost hostObject, re /// /// Checks to see whether all of the passed-in references exist on disk before we launch the compiler. /// - /// RGoel protected bool CheckAllReferencesExistOnDisk() { if (null == References) diff --git a/src/Compilers/Core/MSBuildTask/Vbc.cs b/src/Compilers/Core/MSBuildTask/Vbc.cs index 347293d634993..17038b1c24508 100644 --- a/src/Compilers/Core/MSBuildTask/Vbc.cs +++ b/src/Compilers/Core/MSBuildTask/Vbc.cs @@ -801,7 +801,6 @@ internal static string? GetDefineConstantsSwitch /// thing for csc.exe, the IDE compiler cannot support it. In this situation /// the return value will also be false. /// - /// RGoel private bool InitializeHostCompiler(IVbcHostObject vbcHostObject) { this.HostCompilerSupportsAllParameters = this.UseHostCompilerIfAvailable; @@ -1012,7 +1011,6 @@ private static bool DeferToICompilerOptionsHostObject(string? langVersion, IVbcH /// NoActionReturnSuccess Host compiler was already up-to-date, and we're done. /// NoActionReturnFailure Bad parameters were passed into the task. /// - /// RGoel protected override HostObjectInitializationStatus InitializeHostObject() { if (this.HostObject != null) @@ -1099,7 +1097,6 @@ protected override HostObjectInitializationStatus InitializeHostObject() /// task. Returns true if an appropriate host object was found, it was called to do the compile, /// and the compile succeeded. Otherwise, we return false. /// - /// RGoel protected override bool CallHostObjectToExecute() { Debug.Assert(this.HostObject != null, "We should not be here if the host object has not been set.");