Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[H/3] Distributed Tracing / Telemetry #104783

Open
ManickaP opened this issue Jul 12, 2024 · 1 comment
Open

[H/3] Distributed Tracing / Telemetry #104783

ManickaP opened this issue Jul 12, 2024 · 1 comment
Labels
area-System.Net.Http enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@ManickaP
Copy link
Member

Right now, we emit very short telemetry / activity "wait for connection" for every H/3 request, even if the request is immediately handled by the connection and doesn't wait. Follow queueStartingTimestamp in:

long queueStartingTimestamp = HttpTelemetry.Log.IsEnabled() || Settings._metrics!.RequestsQueueDuration.Enabled ? Stopwatch.GetTimestamp() : 0;

We shouldn't emit those events (if the connection can handle the request immediately). We do have _availableRequestStreamsCount in H3 connection which we could use:

Also, right now the code differs from H/2 pool because of the internal waiting in S.N.Quic OpenOutboundStreamAsync.

connection = await http3ConnectionWaiter.WaitWithCancellationAsync(cancellationToken).ConfigureAwait(false);

vs
connection = await http2ConnectionWaiter.WaitForConnectionAsync(request, this, async, cancellationToken).ConfigureAwait(false);

So if we can bring the code closer to H/2 with this change, it would be an added bonus.

Original discussion: #103922 (comment)

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 12, 2024
@ManickaP ManickaP added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Jul 12, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP ManickaP added this to the 10.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net.Http enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

1 participant