Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebRequest] DefaultMaximumErrorResponseLength should be KB #105387

Closed
ManickaP opened this issue Jul 24, 2024 · 1 comment · Fixed by #105396
Closed

[WebRequest] DefaultMaximumErrorResponseLength should be KB #105387

ManickaP opened this issue Jul 24, 2024 · 1 comment · Fixed by #105396
Assignees
@liveans
Labels
area-System.Net
Milestone
9.0.0

Comments

@ManickaP
Copy link
Member

#97537 follow up. DefaultMaximumErrorResponseLength should be interpreted as kilobytes, not bytes, to behave the same as in Framework, see https://referencesource.microsoft.com/#System/net/System/Net/HttpWebRequest.cs,6150

Discovered in https://github.com/dotnet/dotnet-api-docs/pull/10138/files#r1688603374

cc @liveans
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 24, 2024
@ManickaP ManickaP changed the title [WebRequest] [WebRequest] DefaultMaximumErrorResponseLength should be KB Jul 24, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP ManickaP mentioned this issue Jul 24, 2024
Merged
@liveans liveans added this to the 9.0.0 milestone Jul 24, 2024
@liveans liveans removed the untriaged New issue has not been triaged by the area owner label Jul 24, 2024
@liveans liveans self-assigned this Jul 24, 2024
@liveans liveans mentioned this issue Jul 24, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@liveans liveans

Labels
area-System.Net
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Change DefaultMaximumErrorResponseLength to KB from Byte liveans/dotnet-runtime
2 participants
@ManickaP @liveans