Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] unify Interop.GetHostName #107741

Open
pavelsavara opened this issue Sep 12, 2024 · 3 comments
Open

[wasm] unify Interop.GetHostName #107741

pavelsavara opened this issue Sep 12, 2024 · 3 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Net os-wasi Related to WASI variant of arch-wasm
Milestone

Comments

@pavelsavara
Copy link
Member

From comment

nit: it feels slightly wrong doing this special case in the Interop.GetHostName.cs managed binding layer, but calling into native code just for getting a constant string feels wrong too.

Btw. after looking at it some more I think we have an issue on Browser: we do use emscripten's gethostname() which returns the string emscripten and we just paper over it here:

// In the mono runtime, this maps to gethostname, which returns 'emscripten'.
// Returning the value here allows us to exclude more of the runtime.
public static string MachineName => "localhost";

But Interop.Sys.GetHostName() is used in more places and those would get the "wrong" hostname on Browser. I think I'd be in favor of unifying this and adding the special case for Browser here too.

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Net os-wasi Related to WASI variant of arch-wasm labels Sep 12, 2024
@pavelsavara pavelsavara added this to the 10.0.0 milestone Sep 12, 2024
@pavelsavara pavelsavara self-assigned this Sep 12, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

cc @akoeplinger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-System.Net os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

1 participant