Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include System.IO.Compression.Native in the PGO training set #108073

Open
carlossanlop opened this issue Sep 20, 2024 · 5 comments
Open

Include System.IO.Compression.Native in the PGO training set #108073

carlossanlop opened this issue Sep 20, 2024 · 5 comments
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI PGO tenet-performance Performance related issue
Milestone
10.0.0

Comments

@carlossanlop
Copy link
Member

Include it with the matching training scenario to help C/C++ compilers to generate better code.

This is follow up of dotnet/perf-autofiling-issues#40587 (comment) to help reduce the noise of perf regressions like brotli.

cc @jkotas @jkoritzinsky
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 20, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop mentioned this issue Sep 20, 2024
Closed
@EgorBo
Copy link
Member

EgorBo commented Sep 20, 2024

#67671

@jkotas
Copy link
Member

jkotas commented Sep 20, 2024

which repo is this done? runtime or performance?

The PGO training scenarios live in https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

@jkotas jkotas added the tenet-performance Performance related issue label Sep 20, 2024
@EgorBo
Copy link
Member

EgorBo commented Sep 20, 2024

NOTE: I did file a PR to cover compression (hence, obtain native pgo for it) there, but never landed it for some reason.

@ericstj ericstj added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-System.IO.Compression labels Sep 24, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Sep 25, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI PGO tenet-performance Performance related issue
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
5 participants
@EgorBo @carlossanlop @jkotas @ericstj @JulieLeeMSFT