Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hardcoded NetCoreAppToolCurrent* properties #109329

Open
ViktorHofer opened this issue Oct 29, 2024 · 1 comment
Open

Avoid hardcoded NetCoreAppToolCurrent* properties #109329

ViktorHofer opened this issue Oct 29, 2024 · 1 comment
Labels
area-Infrastructure
Milestone
10.0.0

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 29, 2024 •
edited
Loading

The NetCoreAppToolCurrentVersion is hardcoded to 9.0 which causes issues when building with a newer SDK that doesn't have a shared framework for that given TFM (i.e. inside the VMR). As we already enforce a minimum required SDK version in global.json, it would be better to automatically calculate the NetCoreAppToolCurrentVersion value based on the SDK being used.

The SDK exposes the NETCoreAppMaximumVersion property but unfortunately a little bit too late, after the repo's Directory.Build.props file is imported.

We could avoid the NetCoreAppToolCurrent* properties altogether when the SDK implements dotnet/sdk#29949. That would the ideal path forward.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 29, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 29, 2024
@ViktorHofer ViktorHofer added area-Infrastructure and removed untriaged New issue has not been triaged by the area owner labels Oct 29, 2024
@ViktorHofer ViktorHofer removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 29, 2024
@ViktorHofer ViktorHofer added this to the 10.0.0 milestone Oct 29, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@ViktorHofer ViktorHofer mentioned this issue Oct 29, 2024
Closed
@ViktorHofer ViktorHofer changed the title NetCoreAppToolCurrentVersion property should be automatically calculated Avoid hardcoded NetCoreAppToolCurrent* properties Oct 29, 2024
@ViktorHofer ViktorHofer mentioned this issue Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Infrastructure
Projects
Runtime Infra
Status: No status
Milestone
10.0.0
Development

No branches or pull requests
1 participant
@ViktorHofer