Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pinned Object Heap] DAC_NUMBERGENERATIONS may need to be adjusted #13736

Closed
VSadov opened this issue Nov 5, 2019 · 7 comments
Closed

[Pinned Object Heap] DAC_NUMBERGENERATIONS may need to be adjusted #13736

VSadov opened this issue Nov 5, 2019 · 7 comments

Comments

@VSadov
Copy link
Member

VSadov commented Nov 5, 2019

DAC_NUMBERGENERATIONS is currently 4 and changing it is a compat issue.

We should think what to do with this.

Merge POH into LOH data, have a separate field, etc...

@VSadov VSadov self-assigned this Nov 5, 2019
@mikem8361
Copy link
Member

The existing DacpGcHeapDetails request and DacpGenerationAllocData Request APIs have to be backwards compatible with DAC_NUMBERGENERATIONS = 4. They could return the generations that are similar to the old 0 - 4 generations (I don't know how enough about the GC to really say).

New APIs should be added that return N (instead of a fixed number) generations somehow. There would be a lot of changes to SOS required to use these new APIs. Probably to clrmd too.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@tommcdon tommcdon added the p1 label May 5, 2020
@tommcdon
Copy link
Member

tommcdon commented May 5, 2020

@VSadov do you plan on addressing this issue in .NET 5 timeframe?

@ghost
Copy link

ghost commented May 5, 2020

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

@VSadov
Copy link
Member Author

VSadov commented May 5, 2020

Yes, the plan is to address this for 5.0
From the feedback I hear that this should be addressed sooner rather than later. I'll try to get to this this week.

@davmason
Copy link
Member

@VSadov have you had a chance to work on this yet? We're getting close to the feature complete date and I haven't seen any changes.

@Maoni0
Copy link
Member

Maoni0 commented Jun 17, 2020

API to get # of generations added via this PR

@davmason
Copy link
Member

Fixed in #37853

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants