Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore System.Buffers package in System.IO.Pipelines build #2257

Closed
jkotas opened this issue Jan 27, 2020 · 2 comments
Closed

Restore System.Buffers package in System.IO.Pipelines build #2257

jkotas opened this issue Jan 27, 2020 · 2 comments
Labels
area-System.IO.Pipelines untriaged New issue has not been triaged by the area owner

Comments

@jkotas
Copy link
Member

jkotas commented Jan 27, 2020

Here: https://github.com/dotnet/runtime/blob/master/src/libraries/System.IO.Pipelines/ref/System.IO.Pipelines.csproj#L5

From #2189 (comment) :

Rather than use a ProjectReference we can just restore the package for System.Buffers. Using a ProjectReference here is dangerous since we aren't even shipping that version of System.Buffers.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Jan 27, 2020
@jkotas jkotas mentioned this issue Jan 27, 2020
Merged
@BrennanConroy
Copy link
Member

@jkotas Is this important for 5.0 and since this seems specific to Runtime infra, could you help find someone to do the work?

@jkotas
Copy link
Member Author

jkotas commented Jul 8, 2020

Fixed by #31641

@jkotas jkotas closed this as completed Jul 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.IO.Pipelines untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jkotas @BrennanConroy @Dotnet-GitSync-Bot