-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure: System.Data.Tests.AppDomainsAndFormatInfo.Bug55978 #24206
Comments
Seems to pass if I change the RowFilter string from: |
Perhaps related to the locale issue in #24147 ? |
@Cronan if you temporarily change your culture to en-US does it pass? Might be enough to just set the thread culture at the start of the test. |
I’ll try that this morning |
Quick question @danmosemsft , is changing the locale the right thing to do, unless the test targets a specific locale? Isn't it better to change the test so it doesn't require a specific locale to run? |
@Cronan yes probably that would be better. |
I just wanted to confirm it was a culture issue. Perhaps you'd like to offer that change as a PR? |
I'll test both, and do a PR later today. I have 10 similar issues, but I'll probably deal with them one at a time, otherwise I lose track ... |
Changing the locale worked, but I believe the change I've made will work in |
The test
System.Data.Tests.AppDomainsAndFormatInfo.Bug55978
has failed.The text was updated successfully, but these errors were encountered: