Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Implement better QUIC status code messages #32066

Closed
scalablecory opened this issue Feb 10, 2020 · 2 comments
Closed

[QUIC] Implement better QUIC status code messages #32066

scalablecory opened this issue Feb 10, 2020 · 2 comments
Assignees
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@scalablecory
Copy link
Contributor

Error messages created for status codes should have a more descriptive, and localizable, error.

public static string GetError(uint status)
{
return status switch
{
Success => "SUCCESS",
Pending => "PENDING",
Continue => "CONTINUE",
OutOfMemory => "OUT_OF_MEMORY",
InvalidParameter => "INVALID_PARAMETER",
InvalidState => "INVALID_STATE",
NotSupported => "NOT_SUPPORTED",
NotFound => "NOT_FOUND",
BufferTooSmall => "BUFFER_TOO_SMALL",
HandshakeFailure => "HANDSHAKE_FAILURE",
Aborted => "ABORTED",
AddressInUse => "ADDRESS_IN_USE",
ConnectionTimeout => "CONNECTION_TIMEOUT",
ConnectionIdle => "CONNECTION_IDLE",
InternalError => "INTERNAL_ERROR",
ServerBusy => "SERVER_BUSY",
ProtocolError => "PROTOCOL_ERROR",
VerNegError => "VER_NEG_ERROR",
_ => status.ToString()

@scalablecory scalablecory added this to the 5.0 milestone Feb 10, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 10, 2020
@scalablecory scalablecory removed the untriaged New issue has not been triaged by the area owner label Feb 10, 2020
@karelz karelz modified the milestones: 5.0, Future Feb 21, 2020
@karelz karelz added the enhancement Product code improvement that does NOT require public API changes/additions label Feb 21, 2020
@karelz karelz changed the title Implement better QUIC status code messages [QUIC] Implement better QUIC status code messages Mar 11, 2020
@scalablecory scalablecory modified the milestones: Future, 6.0.0 Aug 11, 2020
@karelz karelz modified the milestones: 6.0.0, Future Jun 22, 2021
@karelz karelz modified the milestones: Future, 7.0.0 Oct 26, 2021
@karelz
Copy link
Member

karelz commented Oct 26, 2021

Triage: Extension of APIs - we should do it in 7.0.

@rzikm
Copy link
Member

rzikm commented Jul 15, 2022

We now have localizable messages for the usual errors which we surface to the user, no further action needed.

@rzikm rzikm closed this as completed Jul 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

5 participants