Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono JIT] Extend Linux perf jitdump functionality #36774

Closed
1 of 2 tasks
fanyang-mono opened this issue May 20, 2020 · 5 comments
Closed
1 of 2 tasks

[Mono JIT] Extend Linux perf jitdump functionality #36774

fanyang-mono opened this issue May 20, 2020 · 5 comments
Assignees
@fanyang-mono
Labels
area-Codegen-JIT-mono enhancement Product code improvement that does NOT require public API changes/additions
Milestone
9.0.0

Comments

@fanyang-mono
Copy link
Member

fanyang-mono commented May 20, 2020 •
edited
Loading

mono/mono#17024 A similar improvement as coreclr is needed. The following is copied from #13540

Added basic support for generating the Linux perf jitdump format. The initial implementation did not include support for adding:

  • Debug info - JIT_CODE_DEBUG_INFO. Provide assembly the line number info to improve annotation.

  • Unwinding info - JIT_CODE_UNWINDING_INFO. Adds dwarf unwind info. This allows/improves recording with the --callgraph dwarf option.

Consider adding these records to improve value of perf jitdump support.

Implementation Notes:

JIT_CODE_DEBUG_INFO & JIT_CODE_UNWINDING_INFO each apply to the next JIT_CODE_LOAD record. This means to properly support multithreading, the information needs to be provide when generating the JIT_CODE_LOAD record

The FEATURE_GDBJIT probably already needs similar info to construct the elf files it passes to gdb. src/vm/gdbjit.cpp may be instructive.
@fanyang-mono fanyang-mono added enhancement Product code improvement that does NOT require public API changes/additions area-Codegen-JIT-mono labels May 20, 2020
@fanyang-mono fanyang-mono self-assigned this May 20, 2020
@ghost
Copy link

ghost commented May 20, 2020

Tagging subscribers to this area: @lewurm
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 20, 2020
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 22, 2020
@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Jun 22, 2020
@SamMonoRT SamMonoRT modified the milestones: 6.0.0, 7.0.0 Jun 10, 2021
@SamMonoRT
Copy link
Member

Low priority - Moving to 7.0.0

@SamMonoRT
Copy link
Member

We'll not get to fixing this. Closing this issue for now.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2022
@saitama951 saitama951 mentioned this issue Apr 20, 2023
Merged
@fanyang-mono
Copy link
Member Author

JIT_CODE_DEBUG_INFO was added by #85107. But JIT_CODE_UNWINDING_INFO hasn't been added yet.

@fanyang-mono fanyang-mono reopened this Jun 12, 2023
@dotnet dotnet unlocked this conversation Nov 24, 2023
@akoeplinger akoeplinger modified the milestones: 7.0.0, 9.0.0 Dec 6, 2023
@steveisok
Copy link
Member

It's highly unlikely we will be able to get to this. Closing.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fanyang-mono fanyang-mono

Labels
area-Codegen-JIT-mono enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
5 participants
@steveisok @akoeplinger @Dotnet-GitSync-Bot @SamMonoRT @fanyang-mono