Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win-arm64] Update EEJitManager::SetCpuInfo in codeman.cpp to support ARMv8.1-RDMA and ARMv8.2-DotProd #39094

Open
echesakov opened this issue Jul 10, 2020 · 1 comment
Open

[win-arm64] Update EEJitManager::SetCpuInfo in codeman.cpp to support ARMv8.1-RDMA and ARMv8.2-DotProd #39094

echesakov opened this issue Jul 10, 2020 · 1 comment
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Milestone
Future

Comments

@echesakov
Copy link
Contributor

echesakov commented Jul 10, 2020 •
edited by BruceForstall
Loading

#38957 adds JIT implementation for the intrinsics from ARMv8.1-RDMA and ARMv8.2-DotProd architectural extensions.
Linux can check for support of these with arm64 ELF hwcaps and #38957 updates PAL_GetJitCpuCapabilityFlags() to enable that.

On Windows this check was traditionally done with IsProcessorFeaturePresent() that at the moment doesn't have the corresponding PF-enum values.

The issue is track the future work for updating EEJitManager::SetCpuInfo() when IsProcessorFeaturePresent() is extended.

category:implementation
theme:hardware-intrinsics
skill-level:beginner
cost:small
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Jul 10, 2020
@echesakov echesakov added this to the Future milestone Jul 10, 2020
@echesakov echesakov added tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly os-windows and removed untriaged New issue has not been triaged by the area owner area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jul 10, 2020
@echesakov echesakov mentioned this issue Jul 10, 2020
Merged
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 13, 2020
@saucecontrol
Copy link
Member

I spent something like 4 hours trying to figure out why Rdm.IsSupported was returning false on my Windows Arm Dev Kit 2023 despite the documentation for the processor indicating the instructions were supported. Turned out to be only disabled in Windows, due to this issue. Since it's been 3 years and IsProcessorFeaturePresent still doesn't support this, is there some other way to detect/enable it in Windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@echesakov @saucecontrol @jeffschwMSFT @Dotnet-GitSync-Bot