Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dead code in CLRConfig #40028

Closed
jkotas opened this issue Jul 28, 2020 · 1 comment · Fixed by #42422
Closed

Cleanup dead code in CLRConfig #40028

jkotas opened this issue Jul 28, 2020 · 1 comment · Fixed by #42422
Assignees
@ivdiazsa
Labels
area-VM-coreclr
Milestone
6.0.0

Comments

@jkotas
Copy link
Member

jkotas commented Jul 28, 2020

A lot of code code under CLRConfig is dead or no longer useful: IgnoreHKLM, IgnoreHKCU, ConfigFile_SystemOnly, ConfigFile_ApplicationFirst, reading config from registry.

Context: #39994 (comment)
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 28, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas jkotas added this to the Future milestone Jul 28, 2020
@jkotas jkotas removed the untriaged New issue has not been triaged by the area owner label Jul 28, 2020
@jkotas jkotas mentioned this issue Jul 28, 2020
Merged
@mangod9 mangod9 modified the milestones: Future, 6.0.0 Jul 29, 2020
@ivdiazsa ivdiazsa self-assigned this Sep 3, 2020
@ivdiazsa ivdiazsa mentioned this issue Sep 18, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ivdiazsa ivdiazsa

Labels
area-VM-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Cleaned up unused CLRConfig code
4 participants
@jkotas @Dotnet-GitSync-Bot @ivdiazsa @mangod9