Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MsQuic #44580

Closed
scalablecory opened this issue Nov 12, 2020 · 13 comments · Fixed by #49823
Closed

Update MsQuic #44580

scalablecory opened this issue Nov 12, 2020 · 13 comments · Fixed by #49823
Assignees
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@scalablecory
Copy link
Contributor

The current System.Net.Quic is referencing https://github.com/microsoft/msquic/tree/dc2a6cf0dd12e273710843158b2f2e612360da0a (from July 2020). We need to update to the latest version of their API, which has mostly stabilized.

@scalablecory scalablecory added this to the 6.0.0 milestone Nov 12, 2020
@scalablecory scalablecory self-assigned this Nov 12, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.


Issue meta data
Issue content: The current System.Net.Quic is referencing https://github.com/microsoft/msquic/tree/dc2a6cf0dd12e273710843158b2f2e612360da0a (from July 2020). We need to update to the latest version of their API, which has mostly stabilized.
Issue author: scalablecory
Assignees: scalablecory
Milestone: [object Object]

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 12, 2020
@huoyaoyuan
Copy link
Member

Is it welcomed to update the interop to function pointers?

@scalablecory
Copy link
Contributor Author

@huoyaoyuan this is already in progress; please avoid conflicting work!

@mclayton7
Copy link
Contributor

Hi @scalablecory are you guys accepting any community contributions for System.Net.Quic? We're looking to use it for some experiments and would gladly help in any way we can.

@mclayton7
Copy link
Contributor

@scalablecory @jkotalik Since msquic has released the first officially supported version of 1.0.0, would you guys accept any community PRs updating to 1.0.0?

@jkotalik
Copy link
Contributor

@scalablecory @geoffkizer thoughts? I'd be fine with this, but want your confirmation.

@geoffkizer
Copy link
Contributor

Community PRs are welcome, but please coordinate with @scalablecory to avoid duplication/conflicts/etc

@mclayton7
Copy link
Contributor

Thanks @jkotalik and @geoffkizer! I've had some difficulties trying to get in contact with @scalablecory, do you guys have any ideas on how to coordinate with him?

@karelz
Copy link
Member

karelz commented Jan 13, 2021

@mclayton7 I will ping him ...

@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Jan 13, 2021
@scalablecory
Copy link
Contributor Author

@mclayton7 I've already got this migration 90% done, but have had to jump on some other things before completing it. It just needs some bug fixes now.

Any interest in submitting a PR into my branch to help finish it? Otherwise, I expect I'll probably resume work on it in early February.

@mclayton7
Copy link
Contributor

@scalablecory absolutely, where is your branch?

@ManickaP
Copy link
Member

ManickaP commented Mar 8, 2021

I'm taking over the task, I'll start with what @scalablecory has in https://github.com/scalablecory/runtime/tree/msquic-update.

@JamesNK
Copy link
Member

JamesNK commented Mar 12, 2021

Ping me once this is done. I'm going to improve ASP.NET Core's TLS integration - https://github.com/dotnet/aspnetcore/issues/30857 - and will wait until after msquic has been updated.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 18, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants