Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming provides similar Xamarin experience in .NET 6 #45714

Closed
7 tasks
agocke opened this issue Dec 7, 2020 · 10 comments
Closed
7 tasks

Trimming provides similar Xamarin experience in .NET 6 #45714

agocke opened this issue Dec 7, 2020 · 10 comments
Labels
area-Meta linkable-framework Issues associated with delivering a linker friendly framework Priority:0 Work that we can't release without User Story A single user-facing feature. Can be grouped under an epic.

Comments

@agocke
Copy link
Member

agocke commented Dec 7, 2020

Mono and CoreCLR continue to increase code sharing and Xamarin is moving to consume more of the .NET Core surface area.

Goals

  • Trimmed Xamarin apps using .NET 6 produce similar behavior as before
  • Trimmed Xamarin apps with .NET 6 are roughly the same size
  • Xamarin apps produce minimal linker warnings and only for linker-unsafe constructs

Work

  • Investigate representative Xamarin app with trimming enabled
    • App still works
    • Catalog and remove warnings
    • Investigate with custom trim steps disabled
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 7, 2020
@agocke agocke added linkable-framework Issues associated with delivering a linker friendly framework Priority:0 Work that we can't release without User Story A single user-facing feature. Can be grouped under an epic. and removed untriaged New issue has not been triaged by the area owner labels Dec 7, 2020
@ghost
Copy link

ghost commented Dec 8, 2020

Tagging subscribers to this area: @vitek-karas, @agocke, @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Mono and CoreCLR continue to increase code sharing and Xamarin is moving to consume more of the .NET Core surface area.

Goals

  • Trimmed Xamarin apps using .NET 6 produce similar behavior as before
  • Trimmed Xamarin apps with .NET 6 are roughly the same size
  • Xamarin apps produce minimal linker warnings and only for linker-unsafe constructs

Work

  • Investigate representative Xamarin app with trimming enabled
    • App still works
    • Catalog and remove warnings
    • Investigate with custom trim steps disabled
Author: agocke
Assignees: -
Labels:

Priority:0, User Story, area-AssemblyLoader-coreclr, linkable-framework

Milestone: -

@marek-safar
Copy link
Contributor

@jeffschwMSFT please don't tag user stories which have nothing to do with assembly loader with that area it's very confusing on the planning

@jeffschwMSFT
Copy link
Member

would you prefer meta? I am fine either way.

@marek-safar
Copy link
Contributor

yep, certainly meta

@marek-safar
Copy link
Contributor

I think we should close this issue, it duplicates existing users stories #44654 and #43078

@jeffschwMSFT
Copy link
Member

It feels distinct to me. This is an engineering tracking list of work. I agree these should be linked together in a coherent way. I see these items as a balance between engineering efficiency and tracking. If it is more efficient to have them separate, I am ok with that.

@marek-safar
Copy link
Contributor

marek-safar commented Dec 9, 2020

Yes, this is engineering tracking and not user-story and we already track them elsewhere in more details

@agocke
Copy link
Member Author

agocke commented Dec 9, 2020

@marek-safar Can you point me to those issues? I'm trying to build up a list of all Pri:0 linker items for Xamarin in .NET 6

@agocke
Copy link
Member Author

agocke commented Dec 9, 2020

#43078 and #44317 seem sufficient -- they cover the user experience for trimming, and size in the second one. Closing in favor of those issues

@agocke agocke closed this as completed Dec 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta linkable-framework Issues associated with delivering a linker friendly framework Priority:0 Work that we can't release without User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

No branches or pull requests

4 participants