Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 5.0 RC2 - self-contained build on Linux - version missing in generated file #46087

Closed
rasmk opened this issue Dec 9, 2020 · 7 comments
Closed
Labels
area-Host untriaged New issue has not been triaged by the area owner

Comments

@rasmk
Copy link

rasmk commented Dec 9, 2020

Already reported on RC2 (microsoft/dotnet#1258), but it was closed without any action.

When I build a self-contained app on Linux (in a Docker container), targeted to win-64, the generated exe file misses version, copyright, and other information. When built on Windows, the information is built into the exe file as expected.

image

@wli3
Copy link

wli3 commented Dec 15, 2020

When build on Linux, SDK does not have access to all Windows APIs needed to set PE bites

@wli3 wli3 transferred this issue from dotnet/sdk Dec 15, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 15, 2020
@wli3
Copy link

wli3 commented Dec 15, 2020

To runtime team, I think we've talked about having a crossplatform API to write PE bites. What's the progress?

@wli3 wli3 removed their assignment Dec 15, 2020
@ghost
Copy link

ghost commented Dec 16, 2020

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

Already reported on RC2 (microsoft/dotnet#1258), but it was closed without any action.

When I build a self-contained app on Linux (in a Docker container), targeted to win-64, the generated exe file misses version, copyright, and other information. When built on Windows, the information is built into the exe file as expected.

image

Author: rasmk
Assignees: -
Labels:

area-Host, untriaged

Milestone: -

@vitek-karas
Copy link
Member

This is currently by design - there's a master issue for this somewhere (can't find it right now). Basically the root cause is that SDK uses Windows API to update native resources for windows executables. These APIs are obviously not available on Linux and instead of failing it will just "skip" that step. This applies to all native resources, so version information, manifests, icons, ...

@rseanhall
Copy link
Contributor

#3828?

@agocke
Copy link
Member

agocke commented Dec 16, 2020

That looks right to me

@ghost ghost locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

7 participants