wasm library test failure EnableAggressiveTrimming - System.ArgumentNullException

[mdh1418]

In effort to run library tests with AOT compilation and EnableAggressiveTrimming enabled on CI #48226 these errors are hit.

EnableAggressiveTrimming related

• System.ArgumentNullException : Value cannot be null. (Parameter 'method')
System.ComponentModel.TypeConverter.Tests log
  Microsoft.Extensions.Http.Tests log
  System.Diagnostics.DiagnosticSource.Tests log

Repro:
Check out changes in
4f17c4e without this, many tests are not discovered.
4e7ab85 this one helps avoid some AOT compilation errors with this exception filter. There shouldn't be exception filter issues anymore.

./build.sh -os Browser -arch wasm -c Release
./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/<path-to-test-proj>

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite Microsoft.Extensions.FileSystemGlobbing.Tests.csproj fails with

System.ArgumentNullException : ArgumentNull_Generic Arg_ParamName_Name, type

microsoft_extensions_filesystemglobbing_fail.txt

Repro:
Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

	<!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved -->
	<assembly fullname="Microsoft.DotNet.RemoteExecutor">
	<type fullname="Microsoft.DotNet.RemoteExecutor.Program">
	<method signature="System.Int32 Main(System.String[])" />
	</type>
	</assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/Microsoft.Extensions.FileSystemGlobbing/tests/Microsoft.Extensions.FileSystemGlobbing.Tests.csproj

Author:	mdh1418
Assignees:	-
Labels:	arch-wasm, area-Infrastructure-libraries
Milestone:	-

[radical]

I'm unable to reproduce this:

  XHarness command issued: wasm test --app=. --engine=V8 --engine-arg=--stack-trace-limit=1000 --js-file=runtime.js --output-directory=/Users/radical/dev/r2/artifacts/bin/Microsoft.Extensions.FileSystemGlobbing.Tests/net6.0-Release/browser-wasm/AppBundle/xharness-output
-- --run WasmTestRunner.dll Microsoft.Extensions.FileSystemGlobbing.Tests.dll -notrait category=OuterLoop -notrait category=failing

  info: 15:35:57.4842150 v8 --expose_wasm --stack-trace-limit=1000 runtime.js -- --run WasmTestRunner.dll Microsoft.Extensions.FileSystemGlobbing.Tests.dll -notrait category=OuterLoop -notrait category=failing

  info: Arguments: --run,WasmTestRunner.dll,Microsoft.Extensions.FileSystemGlobbing.Tests.dll,-notrait,category=OuterLoop,-notrait,category=failing
  info: console.debug: MONO_WASM: Initializing mono runtime
  info: console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
  info: console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
  info: Initializing.....
  info: Discovering: Microsoft.Extensions.FileSystemGlobbing.Tests.dll (method display = ClassAndMethod, method display options = None)
  info: Discovered:  Microsoft.Extensions.FileSystemGlobbing.Tests.dll (found 53 of 53 test cases)
  info: Starting:    Microsoft.Extensions.FileSystemGlobbing.Tests.dll
  info: Finished:    Microsoft.Extensions.FileSystemGlobbing.Tests.dll
  info:
  info: === TEST EXECUTION SUMMARY ===
  info: Total: 53, Errors: 0, Failed: 0, Skipped: 0, Time: 1.665764s
  info:
  info: 15:36:00.5108090 Process v8 exited with 0

  info: Application has finished with exit code: 0
  XHarness exit code: 0
  XHarness artifacts: /Users/radical/dev/r2/artifacts/bin/Microsoft.Extensions.FileSystemGlobbing.Tests/net6.0-Release/browser-wasm/AppBundle/xharness-output

[naricc]

I will take this one now; I will assign more of these to myself once I do this one and get a better estimate for the work involved.

[SamMonoRT]

@radical - this should be fixed, Please confirm if so, and close the issue

[naricc]

I believe this is fixed by: #50645

[radical]

AFAICS, this is fixed.