Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasm][AOT] Assert.True() failure #49246

Closed
1 task
mdh1418 opened this issue Mar 5, 2021 · 4 comments
Closed
1 task

[Wasm][AOT] Assert.True() failure #49246

mdh1418 opened this issue Mar 5, 2021 · 4 comments
Labels
Milestone

Comments

@mdh1418
Copy link
Member

mdh1418 commented Mar 5, 2021

In effort to run library tests with AOT compilation and EnableAggressiveTrimming enabled on CI #48226 these errors are hit.

  • Assert.True() Failure
    Microsoft.Extensions.Configuration.Json.Tests log
    Common.Tests log
    System.Xml.XmlSchemaSet.Tests log
    Microsoft.Extensions.Configuration.Ini.Tests log
    Microsoft.Extensions.Configuration.Xml.Tests log
    Microsoft.Extensions.FileProviders.Composite.Tests log
    System.Diagnostics.StackTrace.Tests log

Repro:
Check out changes in
4f17c4e without this, many tests are not discovered.
4e7ab85 this one helps avoid some AOT compilation errors with this exception filter. There shouldn't be exception filter issues anymore.

./build.sh -os Browser -arch wasm -c Release
./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/<path-to-test-proj>

@ghost
Copy link

ghost commented Mar 5, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In effort to run library tests with AOT compilation and EnableAggressiveTrimming enabled on CI #48226 these errors are hit.

  • Assert.True() Failure
    Microsoft.Extensions.Configuration.Json.Tests log
    Common.Tests log
    System.Xml.XmlSchemaSet.Tests log
    Microsoft.Extensions.Configuration.Ini.Tests log
    Microsoft.Extensions.Configuration.Xml.Tests log
    Microsoft.Extensions.FileProviders.Composite.Tests log
    System.Diagnostics.StackTrace.Tests log

Repro:
Check out changes in https://github.com/steveisok/runtime/tree/build-wasm-aot-helix
./build.sh -os Browser -arch wasm -c Release
./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/<path-to-test-proj>

Author: mdh1418
Assignees: -
Labels:

arch-wasm, area-Infrastructure-libraries

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 5, 2021
@lewing
Copy link
Member

lewing commented Mar 8, 2021

Microsoft.Extensions.Configuration.Json is failing because the resource isn't getting loaded from the Satellite assembly. I haven't looked at the others yet but they are likely similar.

  info: 16:10:00.8540320 Running v8 --expose_wasm --stack-trace-limit=1000 runtime.js -- --run WasmTestRunner.dll Microsoft.Extensions.Configuration.Json.Tests.dll -notrait category=OuterLoop -notrait category=failing
        
        
  info: console.info: Arguments: --run,WasmTestRunner.dll,Microsoft.Extensions.Configuration.Json.Tests.dll,-notrait,category=OuterLoop,-notrait,category=failing
  info: console.debug: MONO_WASM: Initializing mono runtime
  info: console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
  info: console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
  info: console.info: Initializing.....
  info: Discovering: Microsoft.Extensions.Configuration.Json.Tests.dll (method display = ClassAndMethod, method display options = None)
  info: Discovered:  Microsoft.Extensions.Configuration.Json.Tests.dll (found 40 of 40 test cases)
  info: Starting:    Microsoft.Extensions.Configuration.Json.Tests.dll
  fail: [FAIL] Microsoft.Extensions.Configuration.JsonConfigurationTest.ThrowExceptionWhenUnexpectedEndFoundBeforeFinishParsing
  info: Assert.Contains() Failure
  info: Not found: Could not parse the JSON file.
  info: In value:  Error_JSONParseError
  info: 
  fail: [FAIL] Microsoft.Extensions.Configuration.JsonConfigurationTest.ThrowFormatExceptionWhenFileIsEmpty
  info: Assert.Contains() Failure
  info: Not found: Could not parse the JSON file.
  info: In value:  Error_JSONParseError
  info: 
  fail: [FAIL] Microsoft.Extensions.Configuration.JsonConfigurationTest.ThrowExceptionWhenMissingCurlyBeforeFinishParsing
  info: Assert.Contains() Failure
  info: Not found: Could not parse the JSON file.
  info: In value:  Error_JSONParseError
  info: 
  info: Finished:    Microsoft.Extensions.Configuration.Json.Tests.dll
  info: 
  info: === TEST EXECUTION SUMMARY ===
  info: Total: 40, Errors: 0, Failed: 3, Skipped: 0, Time: 0.3818139s
  info: 
  info: 16:10:02.1931050 Process v8 exited with 1
        
  fail: Application has finished with exit code 1 but 0 was expected

https://github.com/dotnet/runtime/search?q=Error_JSONParseError

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Mar 8, 2021
@lewing lewing added this to the 6.0.0 milestone Mar 8, 2021
@radical
Copy link
Member

radical commented Mar 8, 2021

Microsoft.Extensions.Configuration.Json is failing because the resource isn't getting loaded from the Satellite assembly. I haven't looked at the others yet but they are likely similar.

Which satellite assemblies?

@radical
Copy link
Member

radical commented Jun 24, 2021

Closing this, as this predates the newer set of aot test issues that are tracked with wasm-aot-test label.

@radical radical closed this as completed Jun 24, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants