Add a unit test to validate FX EventSource Events that are trimmer suppressed

[LakshanF]

Description

EventSource's WriteEvent(int,params object?[]) and Write<T> methods have been annotated with the RequiresUnreferencedCode to prevent developers who derive EventSource to get into trimming problems due to serialization issue. Developers need to manually look at the event method arguments and make them safe (either via additional dependecy attributes or if the arguments are primitive)

As part of making the change to add the RequiresUnreferencedCode, we manually looked at all the library eventsource and ensured that they are safe as described above.

We need to add a test (likely a reflection based one) to ensure that these methods continue to be safe

Configuration

.NET 6.0

Regression?

No

Other information

Take a look at similar tests @eerhardt added for other areas in the library

[ghost]

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

EventSource's WriteEvent(int,params object?[]) and Write methods have been annotated with the RequiresUnreferencedCode to prevent developers who derive EventSource to get into trimming problems due to serialization issue. Developers need to manually look at the event method arguments and make them safe (either via additional dependecy attributes or if the arguments are primitive)

As part of making the change to add the RequiresUnreferencedCode, we manually looked at all the library eventsource and ensured that they are safe as described above.

We need to add a test (likely a reflection based one) to ensure that these methods continue to be safe

Configuration

.NET 6.0

Regression?

No

Other information

Take a look at similar tests @eerhardt added for other areas in the library

Author:	LakshanF
Assignees:	LakshanF
Labels:	area-System.Diagnostics.Tracing, untriaged
Milestone:	-

[ghost]

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

EventSource's WriteEvent(int,params object?[]) and Write methods have been annotated with the RequiresUnreferencedCode to prevent developers who derive EventSource to get into trimming problems due to serialization issue. Developers need to manually look at the event method arguments and make them safe (either via additional dependecy attributes or if the arguments are primitive)

As part of making the change to add the RequiresUnreferencedCode, we manually looked at all the library eventsource and ensured that they are safe as described above.

We need to add a test (likely a reflection based one) to ensure that these methods continue to be safe

Configuration

.NET 6.0

Regression?

No

Other information

Take a look at similar tests @eerhardt added for other areas in the library

Author:	LakshanF
Assignees:	LakshanF
Labels:	area-System.Diagnostics.Tracing, linkable-framework, untriaged
Milestone:	-

[LakshanF]

Cannot think of an easy way to add a generic test and moving this issue the next version. The best practice for any new Framework EventSource should have the following flavor (and avoid the need for a generic testing approach) but need to get consensus and evangelize this;

• Ensure that the tests for the new EventSource run in trimmed mode (will ensure that the above problem will be caught)
• Ensure that there is no unused code in the new EventSource since the trimmer will keep all the members as specified in the class tagging. See Custom EventSources in shared library seem to have unused code #54859 for more details

[LakshanF]

Added a manifest trimming test, #56463. And there is a good smoke EventSource test in the same directory that should cover the basic scenarios testing for .NET6

[tommcdon]

Moving older issues to the Future milestone as it is unlikely we will have time to address this in the .NET 7 timeframe