Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Enable wasm relinking for Trimming tests running in dotnet-linker-tests #49790

Closed
radical opened this issue Mar 18, 2021 · 4 comments
Closed
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone

Comments

@radical
Copy link
Member

radical commented Mar 18, 2021

We do wasm relinking in some cases by default now (eg. in Release config). This breaks in case of Trimming tests run under dotnet-linker-tests, because it cannot find mono-aot-cross. It needs this to essentially invoke:

"$(MonoAotCrossCompilerPath)" --print-icall-table > "$(_WasmIntermediateOutputPath)runtime-icall-table.h"

Wasm relinking has been disabled in this case, for now (#49774). But this needs to be fixed.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 18, 2021
@radical radical added the arch-wasm WebAssembly architecture label Mar 18, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

We do wasm relinking in some cases by default now (eg. in Release config). This breaks in case of Trimming tests run under dotnet-linker-tests, because it cannot find mono-aot-cross. It needs this to essentially invoke:

"$(MonoAotCrossCompilerPath)" --print-icall-table > "$(_WasmIntermediateOutputPath)runtime-icall-table.h"

Wasm relinking has been disabled in this case, for now (#49774). But this needs to be fixed.

Author: radical
Assignees: -
Labels:

arch-wasm, untriaged

Milestone: -

@radical radical removed the untriaged New issue has not been triaged by the area owner label Mar 18, 2021
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 23, 2021
@lewing lewing modified the milestones: 6.0.0, 7.0.0 Jul 31, 2021
@ilonatommy
Copy link
Member

Have we made any progress here @radekdoulik?

@radical radical modified the milestones: 7.0.0, 8.0.0 Aug 11, 2022
@lewing lewing closed this as completed Jul 25, 2023
@lewing
Copy link
Member

lewing commented Jul 25, 2023

Considering this resolved

@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

No branches or pull requests

5 participants