Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system.data.tests.appdomainsandformatinfo.bug55978 failing intermittently on wasm #51131

Closed
runfoapp bot opened this issue Apr 12, 2021 · 7 comments
Closed
Labels
arch-wasm WebAssembly architecture area-System.Data untriaged New issue has not been triaged by the area owner

Comments

@runfoapp
Copy link

runfoapp bot commented Apr 12, 2021

Runfo Tracking Issue: system.data.tests.appdomainsandformatinfo.bug55978 failing intermittently on wasm

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1081569 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 1 1
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 12, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@danmoseley danmoseley added arch-wasm WebAssembly architecture area-System.Data labels Apr 12, 2021
@ghost
Copy link

ghost commented Apr 12, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Tracking Issue: system.data.tests.appdomainsandformatinfo.bug55978 failing intermittently on wasm

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1081569 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 1 1
Author: runfoapp[bot]
Assignees: -
Labels:

arch-wasm, area-System.Data, untriaged

Milestone: -

@danmoseley
Copy link
Member

Probably @lewing team should look first
and not System.Data folks

@lewing
Copy link
Member

lewing commented Apr 12, 2021

cc @CoffeeFlux

@CoffeeFlux
Copy link
Contributor

Weird failure, test is:

        [Fact]
        public void Bug55978()
        {
            DataTable dt = new DataTable();
            dt.Columns.Add("StartDate", typeof(DateTime));

            DataRow dr;
            DateTime date = DateTime.Now;

            for (int i = 0; i < 10; i++)
            {
                dr = dt.NewRow();
                dr["StartDate"] = date.AddDays(i);
                dt.Rows.Add(dr);
            }

            DataView dv = dt.DefaultView;
            dv.RowFilter = string.Format(CultureInfo.InvariantCulture,
                                "StartDate >= #{0}# and StartDate <= #{1}#",
                                DateTime.Now.AddDays(2),
                                DateTime.Now.AddDays(4));
            Assert.Equal(10, dt.Rows.Count);
            Assert.Equal(2, dv.Count);
        }

Doesn't seem actionable unless it shows up more frequently.

@lewing
Copy link
Member

lewing commented May 5, 2021

I'm not sure what Bug55978 was but it does seem like

--- a/src/libraries/System.Data.Common/tests/System/Data/DataTableTest.cs
+++ b/src/libraries/System.Data.Common/tests/System/Data/DataTableTest.cs
@@ -3816,8 +3816,8 @@ public void Bug55978()
             DataView dv = dt.DefaultView;
             dv.RowFilter = string.Format(CultureInfo.InvariantCulture,
                                 "StartDate >= #{0}# and StartDate <= #{1}#",
-                                DateTime.Now.AddDays(2),
-                                DateTime.Now.AddDays(4));
+                                date.AddDays(2),
+                                date.AddDays(4));
             Assert.Equal(10, dt.Rows.Count);
             Assert.Equal(2, dv.Count);

would be a more stable test 😉

@lewing
Copy link
Member

lewing commented Jun 17, 2021

The data is gone and this doesn't seem to be recurring so closing.

@lewing lewing closed this as completed Jun 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Data untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

3 participants