-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system.data.tests.appdomainsandformatinfo.bug55978 failing intermittently on wasm #51131
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsRunfo Tracking Issue: system.data.tests.appdomainsandformatinfo.bug55978 failing intermittently on wasm
Build Result Summary
|
Probably @lewing team should look first |
cc @CoffeeFlux |
Weird failure, test is: [Fact]
public void Bug55978()
{
DataTable dt = new DataTable();
dt.Columns.Add("StartDate", typeof(DateTime));
DataRow dr;
DateTime date = DateTime.Now;
for (int i = 0; i < 10; i++)
{
dr = dt.NewRow();
dr["StartDate"] = date.AddDays(i);
dt.Rows.Add(dr);
}
DataView dv = dt.DefaultView;
dv.RowFilter = string.Format(CultureInfo.InvariantCulture,
"StartDate >= #{0}# and StartDate <= #{1}#",
DateTime.Now.AddDays(2),
DateTime.Now.AddDays(4));
Assert.Equal(10, dt.Rows.Count);
Assert.Equal(2, dv.Count);
} Doesn't seem actionable unless it shows up more frequently. |
I'm not sure what Bug55978 was but it does seem like --- a/src/libraries/System.Data.Common/tests/System/Data/DataTableTest.cs
+++ b/src/libraries/System.Data.Common/tests/System/Data/DataTableTest.cs
@@ -3816,8 +3816,8 @@ public void Bug55978()
DataView dv = dt.DefaultView;
dv.RowFilter = string.Format(CultureInfo.InvariantCulture,
"StartDate >= #{0}# and StartDate <= #{1}#",
- DateTime.Now.AddDays(2),
- DateTime.Now.AddDays(4));
+ date.AddDays(2),
+ date.AddDays(4));
Assert.Equal(10, dt.Rows.Count);
Assert.Equal(2, dv.Count); would be a more stable test 😉 |
The data is gone and this doesn't seem to be recurring so closing. |
Runfo Tracking Issue: system.data.tests.appdomainsandformatinfo.bug55978 failing intermittently on wasm
Build Result Summary
The text was updated successfully, but these errors were encountered: