Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][tests] Tracking issue for test failures with AOT #51251

Closed
radical opened this issue Apr 14, 2021 · 5 comments
Closed

[wasm][tests] Tracking issue for test failures with AOT #51251

radical opened this issue Apr 14, 2021 · 5 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test
Milestone

Comments

@radical
Copy link
Member

radical commented Apr 14, 2021

This is for tracking test failures when running with AOT.

To reproduce locally:

  1. use the branch from the second PR
  2. $ /dotnet.sh build /p:Configuration=Release /p:TargetOS=Browser /p:TargetArchitecture=wasm /t:Test /path/to/project/file /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true
  3. If you are not able to reproduce it with the above, then try building with /p:BuildAOTTestsOnHelix=true to the above command line
  4. If you still cannot reproduce, then ask on the discord channel, as it might be a helix issue

tips:

  • make sure to assign the issue to yourself, if you are working on it
  • You can add /p:DebuggerSupport=true to get line numbers
  • Add /p:WasmNativeDebugSymbols=true /p:WasmNativeStrip=false for better traces
  • You can try /p:_WasmDevel=true for improving the build times (a bit)
  • It can be useful to run the tests in a browser. For that:
    • WasmXHarnessArgs="--no-headless --no-quit" Scenario=WasmTestOnBrowser - this will launch chrome in "headed" mode, and it won't quit after the tests are done
    • And adding WasmXHarnessMonoArgs="--runtime-arg=--trace=E" - will get you extra traces, but with v8 you will only see Native stacktrace (mono_llvm_cpp_throw_exception), but in the browser's js console, you can see the full trace for that
Name Issue crash/build-error
System.IO.Pipelines #50959 n
System.Runtime.Extensions.Tests #51676 n
System.Runtime.Serialization.Xml.ReflectionOnly.Tests #51679 n
System.Runtime.Tests #52393 n
System.Text.Json.Tests #51961 y

Tests that were failing till very recently

Name Issue crash/build-error
System.Reflection.Tests #51673 n
System.Runtime.Loader.DefaultContext.Tests #51680 y
System.Runtime.Loader.Tests #51678 n
System.Text.Encodings.Web.Tests #50965 y
System.CodeDom.Tests #51723 y

(not an exhaustive list. See label wasm-aot-test for all the issues)

@radical radical added arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test labels Apr 14, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 14, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This is for tracking test failures when running with AOT.

To reproduce locally:

  1. use the branch from the second PR
  2. $ /dotnet.sh build /p:Configuration=Release /p:TargetOS=Browser /p:TargetArchitecture=wasm /t:Test /path/to/project/file /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true
  3. If you are not able to reproduce it with the above, then try building with /p:BuildAOTTestsOnHelix=true to the above command line
  4. If you still cannot reproduce, then ask on the discord channel, as it might be a helix issue

tips:

  • make sure to assign the issue to yourself, if you are working on it
  • You can add /p:DebuggerSupport=true to get line numbers
  • Add /p:WasmNativeDebugSymbols=true /p:WasmNativeStrip=false for better traces
  • You can try /p:_WasmDevel=true for improving the build times (a bit)
Author: radical
Assignees: -
Labels:

arch-wasm, area-Codegen-AOT-mono, wasm-aot-test

Milestone: -

@radical radical changed the title [wasm][tests] Tracking issue for errors with AOT [wasm][tests] Tracking issue for test errors with AOT Apr 14, 2021
@radical radical changed the title [wasm][tests] Tracking issue for test errors with AOT [wasm][tests] Tracking issue for test failures with AOT Apr 14, 2021
@radical
Copy link
Member Author

radical commented Apr 14, 2021

@SamMonoRT
Copy link
Member

cc @fanyang-mono

@radical radical removed the untriaged New issue has not been triaged by the area owner label Apr 23, 2021
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 24, 2021
@SamMonoRT
Copy link
Member

@radical @lewing - any more work left for this tracking issue ?

@lewing lewing modified the milestones: 6.0.0, 7.0.0 Aug 17, 2021
@radical
Copy link
Member Author

radical commented Mar 7, 2022

This can be closed now, as the original work is done.

@radical radical closed this as completed Mar 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test
Projects
None yet
Development

No branches or pull requests

3 participants