-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download CoreCLR product download for Mono failed in CI #53421
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @directhex Issue Details
cc @naricc @akoeplinger @steveisok
|
@ViktorHofer do you have an example build log? no idea why this would fail. |
Based on his comments I imagine it's https://dev.azure.com/dnceng/public/_build/results?buildId=1161146&view=logs&j=ecfd4eca-a79d-5010-5cc7-224332d2af8a&t=236bfeb8-30a9-5be2-64ba-6046b281294b Perhaps this is due to the other CoreCLR build leg failing? Tracked in #53420 That'd still be a problem here since we shouldn't sequence builds if their dependent builds failed. |
Sorry for the to include the link. Eric already found the respective build. Question, why does Mono still depend on CoreCLR assets? Shouldn't we avoid such a dependency? |
That's the way these runtime tests are setup now, I'm not familiar exactly why they're doing it that way. Presumably so we don't need to rebuild all the tests again and just swap the runtime in CORE_ROOT. |
@ViktorHofer Right now for the runtime tests, we actually have to build coreclr to get corerun, and then patch it with mono runtime bits. I have an issue assigned to me to fix this by just building a more version of "corerun", but haven't gotten to it yet. |
"Fixed" in #54094 |
cc @naricc @akoeplinger @steveisok
The text was updated successfully, but these errors were encountered: