Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp #54598

Closed
ViktorHofer opened this issue Jun 23, 2021 · 1 comment · Fixed by #54995
Closed

Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp #54598

ViktorHofer opened this issue Jun 23, 2021 · 1 comment · Fixed by #54995
Labels
area-System.Net.Http enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Milestone
6.0.0

Comments

@ViktorHofer
Copy link
Member

When adding a NetCoreAppCurrent TFM to System.Net.Http.WinHttpHandler, more than 100 nullable warnings pop up that would need to be addressed.

Meanwhile the <Nullable> setting for NetCoreAppCurrent is set to annotations only, to avoid the warnings in the build.

Related: #54012
@ghost
Copy link

ghost commented Jun 23, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

When adding a NetCoreAppCurrent TFM to System.Net.Http.WinHttpHandler, more than 100 nullable warnings pop up that would need to be addressed.

Meanwhile the <Nullable> setting for NetCoreAppCurrent is set to annotations only, to avoid the warnings in the build.

Related: #54012

Author: ViktorHofer
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 23, 2021
@ViktorHofer ViktorHofer added the help wanted [up-for-grabs] Good issue for external contributors label Jun 23, 2021
@karelz karelz added this to the Future milestone Jun 23, 2021
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Jun 23, 2021
@huoyaoyuan huoyaoyuan mentioned this issue Jul 1, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 1, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 14, 2021
@karelz karelz modified the milestones: Future, 6.0.0 Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Http enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp huoyaoyuan/runtime
2 participants
@karelz @ViktorHofer