Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Throw PNSE for unsupported SslOptions (client and server) #55759

Closed
ManickaP opened this issue Jul 15, 2021 · 4 comments · Fixed by #55877 or #56923
Closed

[QUIC] Throw PNSE for unsupported SslOptions (client and server) #55759

ManickaP opened this issue Jul 15, 2021 · 4 comments · Fixed by #55877 or #56923
Assignees
@wfurt
Labels
area-System.Net.Quic
Milestone
6.0.0

Comments

@ManickaP
Copy link
Member

Todo: please at least make a list which one are not supported.

Related #32069 and #32071
@ManickaP ManickaP added this to the 6.0.0 milestone Jul 15, 2021
@ghost
Copy link

ghost commented Jul 15, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Todo: please at least make a list which one are not supported.

Related #32069 and #32071

Author: ManickaP
Assignees: wfurt
Labels:

area-System.Net.Quic
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 15, 2021
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Jul 15, 2021
@wfurt wfurt mentioned this issue Jul 17, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 17, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 21, 2021
@wfurt
Copy link
Member

wfurt commented Jul 21, 2021

reverted by #56097

@wfurt wfurt reopened this Jul 21, 2021
@ManickaP
Copy link
Member Author

ManickaP commented Aug 4, 2021

@wfurt do you still plan to tackle this for 6.0 or should we postpone it / close it in favor of adding the implementation?

@wfurt
Copy link
Member

wfurt commented Aug 4, 2021

I'm not sure what we want to do here. I can fix the other tests and finish this easily. But I worry somewhat about compat and causing more harm. For the local certificate selection callback somebody may have it set by default (like we do) in case server asks for certificate ... and that may be never in case of H3.

So perhaps I can do everything but LocalCertificateSelectionCallback ???

@wfurt wfurt mentioned this issue Aug 5, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 5, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wfurt wfurt

Labels
area-System.Net.Quic
Projects
None yet
Milestone
6.0.0
2 participants
@ManickaP @wfurt