Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCInfo: Save bits in Code Offset encoding #5677

Closed
swaroop-sridhar opened this issue Apr 21, 2016 · 0 comments · Fixed by #104336
Closed

GCInfo: Save bits in Code Offset encoding #5677

swaroop-sridhar opened this issue Apr 21, 2016 · 0 comments · Fixed by #104336
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@swaroop-sridhar
Copy link
Contributor

Core Offsets on Thumb/Arm/Arm64 are 2/4/8 byte aligned.
So, GCInfo encoding can save bits by eliminating the last few bits in the offset in NORMALIZE_CODE_OFFSET()

However, one problem with this is in the code-offsets for safepoints, which are encoded with a -1 adjustment:
https://github.com/dotnet/coreclr/blob/master/src/gcinfo/gcinfoencoder.cpp#L1210-L1218
https://github.com/dotnet/coreclr/blob/master/src/vm/gcinfodecoder.cpp#L397-L401
So, currently code offsets are encoded as-is.

So, this work item is to take reduce the number of bits used in the encoding by:

  1. Separating the normalization for safepoints (which uses a -1 adjustment) and fully-interruptible code (where no adjustment is used).
  2. Have an architecture specific adjustment value (ex: -1 on X86, -2 on ARM, -4 on ARM64) so that we can take advantage of the alignment, and still keep the offset within the safepoint instruction.

category:throughput
theme:gc-info
skill-level:intermediate
cost:medium

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 30, 2020
@msftgits msftgits added this to the Future milestone Jan 30, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@TIHan TIHan removed the JitUntriaged CLR JIT issues needing additional triage label Nov 1, 2023
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jul 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants