Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP/3] Loopback server should dispose underlying QUIC connection #57779

Closed
geoffkizer opened this issue Aug 19, 2021 · 4 comments · Fixed by #72713
Closed

[HTTP/3] Loopback server should dispose underlying QUIC connection #57779

geoffkizer opened this issue Aug 19, 2021 · 4 comments · Fixed by #72713
Assignees
@ManickaP
Labels
area-System.Net.Http test-bug Problem in test source code (most likely)
Milestone
7.0.0

Comments

@geoffkizer
Copy link
Contributor

The logic to do this is currently disabled: https://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/System/Net/Http/Http3LoopbackConnection.cs#L57

We should re enable this and fix tests accordingly.
@geoffkizer geoffkizer added area-System.Net.Http test-bug Problem in test source code (most likely) labels Aug 19, 2021
@geoffkizer geoffkizer added this to the 7.0.0 milestone Aug 19, 2021
@ghost
Copy link

ghost commented Aug 19, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The logic to do this is currently disabled: https://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/System/Net/Http/Http3LoopbackConnection.cs#L57

We should re enable this and fix tests accordingly.

Author: geoffkizer
Assignees: -
Labels:

area-System.Net.Http, test bug
Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 19, 2021
@karelz karelz changed the title HTTP3: Loopback server should dispose underlying QUIC connection [HTTP/3] Loopback server should dispose underlying QUIC connection Aug 20, 2021
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Aug 20, 2021
@CarnaViire CarnaViire mentioned this issue Aug 24, 2021
Merged
This was referenced Aug 25, 2021
Merged
Closed
@karelz
Copy link
Member

karelz commented Nov 16, 2021

Triage: We disabled the behavior to make tests pass on all versions of HTTP -- we will have to review the failures again once we work on this.

@karelz
Copy link
Member

karelz commented Jun 14, 2022

Triage: Try it and see what it does. If there are too many issues, we are fine with Future.

@ManickaP
Copy link
Member

Let's revisit this while working on CloseAsync/DisposeAsync in #68902

@ManickaP ManickaP mentioned this issue Jul 23, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 23, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 24, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ManickaP ManickaP

Labels
area-System.Net.Http test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[QUIC] Return connection dispose in H3loopback connection ManickaP/runtime
4 participants
@karelz @jeffschwMSFT @ManickaP @geoffkizer